net/quic/quic_stream_factory.h - Issue 1149243003: Returning scoped_ptr instead of raw pointer in QuicInfoToValue in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_factory.h

Issue 1149243003: Returning scoped_ptr instead of raw pointer in QuicInfoToValue in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_stream_factory.h

diff --git a/net/quic/quic_stream_factory.h b/net/quic/quic_stream_factory.h

index 3b4a573fdec1ee6bf6551782b65307c4014b68ef..185da1ff563123fa386e191b34dfc4a53c42a414 100644

--- a/net/quic/quic_stream_factory.h

+++ b/net/quic/quic_stream_factory.h

@@ -162,7 +162,7 @@ class NET_EXPORT_PRIVATE QuicStreamFactory

// Closes all current sessions.

void CloseAllSessions(int error);

- base::Value* QuicStreamFactoryInfoToValue() const;

+ scoped_ptr<base::Value> QuicStreamFactoryInfoToValue() const;

// Delete all cached state objects in |crypto_config_|.

void ClearCachedStatesInCryptoConfig();

« no previous file with comments | « net/quic/quic_client_session.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »