net/quic/quic_client_session.h - Issue 1149243003: Returning scoped_ptr instead of raw pointer in QuicInfoToValue in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_client_session.h

Issue 1149243003: Returning scoped_ptr instead of raw pointer in QuicInfoToValue in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_client_session.h

diff --git a/net/quic/quic_client_session.h b/net/quic/quic_client_session.h

index 6b7dab68fdbf6e9f2d70fa44df6c1ad394a12b26..4300dcd8c030ba048b9300c90293d00d7b586f46 100644

--- a/net/quic/quic_client_session.h

+++ b/net/quic/quic_client_session.h

@@ -178,7 +178,7 @@ class NET_EXPORT_PRIVATE QuicClientSession : public QuicClientSessionBase,

void CloseSessionOnErrorAndNotifyFactoryLater(int error,

QuicErrorCode quic_error);

- base::Value* GetInfoAsValue(const std::set<HostPortPair>& aliases);

+ scoped_ptr<base::Value> GetInfoAsValue(const std::set<HostPortPair>& aliases);

const BoundNetLog& net_log() const { return net_log_; }

« no previous file with comments | « net/http/http_network_session.cc ('k') | net/quic/quic_client_session.cc » ('j') | no next file with comments »