Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/log/net_log_util.cc

Issue 1149243003: Returning scoped_ptr instead of raw pointer in QuicInfoToValue in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/http_network_session.cc ('K') | « net/http/http_network_session.cc ('k') | net/quic/quic_client_session.h » ('j') | net/quic/quic_stream_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/log/net_log_util.cc
diff --git a/net/log/net_log_util.cc b/net/log/net_log_util.cc
index 6b78359c915ac0099024811e9301d80dc643d5f7..3d004702a632d2ace8201cc89f54660726f7b3eb 100644
--- a/net/log/net_log_util.cc
+++ b/net/log/net_log_util.cc
@@ -450,7 +450,7 @@ NET_EXPORT scoped_ptr<base::DictionaryValue> GetNetInfo(
if (info_sources & NET_INFO_QUIC) {
net_info_dict->Set(NetInfoSourceToString(NET_INFO_QUIC),
- http_network_session->QuicInfoToValue());
+ http_network_session->QuicInfoToValue().Pass());
eroman 2015/05/25 17:48:56 Remove .Pass()
payal.pandey 2015/05/26 06:24:15 Done.
}
if (info_sources & NET_INFO_HTTP_CACHE) {
« net/http/http_network_session.cc ('K') | « net/http/http_network_session.cc ('k') | net/quic/quic_client_session.h » ('j') | net/quic/quic_stream_factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698