Android: Enable 'crash GPU process on context lost' WAR for Mali-400

Android: Enable 'crash GPU process on context lost' WAR for Mali-400

BUG=496438
NOTRY=True

Committed: https://crrev.com/759299794cf4b9ba4b783cf1c5d996dc3d7f215b
Cr-Commit-Position: refs/heads/master@{#333076}

[no sievers, 2015-06-04 00:45:27]

sievers@chromium.org changed reviewers:
+ zmo@chromium.org

[no sievers, 2015-06-04 00:45:34]

ptal

[Zhenyao Mo, 2015-06-04 00:58:13]

LGTM with comments updated

https://codereview.chromium.org/1149233004/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1149233004/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:11339: LOG(ERROR) << "Exiting
GPU process because some drivers cannot reset"
The log message and the above comment are all about D3D.  You need to update
that.

[no sievers, 2015-06-04 19:26:21]

Could you take another look?

I had to change it since the 'IsLowEnd' check didn't handle Android WebView
(kSingleProcess).

[Zhenyao Mo, 2015-06-04 19:44:06]

On 2015/06/04 19:26:21, sievers wrote:
> Could you take another look?
> 
> I had to change it since the 'IsLowEnd' check didn't handle Android WebView
> (kSingleProcess).

I am a bit confused about this comment.  This CL disallows exit on context lost
if it's single process, so Android WebView is still not handled.  Is that the
intended behavior?

[no sievers, 2015-06-04 20:21:26]

On 2015/06/04 19:44:06, Zhenyao Mo wrote:
> On 2015/06/04 19:26:21, sievers wrote:
> > Could you take another look?
> > 
> > I had to change it since the 'IsLowEnd' check didn't handle Android WebView
> > (kSingleProcess).
> 
> I am a bit confused about this comment.  This CL disallows exit on context
lost
> if it's single process, so Android WebView is still not handled.  Is that the
> intended behavior?

Android WebView uses single-process.

[Zhenyao Mo, 2015-06-04 20:26:54]

LGTM

[no sievers, 2015-06-04 21:48:35]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2015-06-04 21:50:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149233004/20001

[commit-bot: I haz the power, 2015-06-04 21:58:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-04 21:58:46]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[no sievers, 2015-06-04 22:49:29]

The CQ bit was checked by sievers@chromium.org

[no sievers, 2015-06-04 22:49:30]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1149233004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-04 22:50:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149233004/40001

[commit-bot: I haz the power, 2015-06-05 01:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-05 01:05:59]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[no sievers, 2015-06-05 17:04:01]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2015-06-05 17:04:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149233004/40001

[commit-bot: I haz the power, 2015-06-05 17:08:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-05 17:09:13]

Patchset 3 (id:??) landed as
https://crrev.com/759299794cf4b9ba4b783cf1c5d996dc3d7f215b
Cr-Commit-Position: refs/heads/master@{#333076}