Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1149233003: Exposed unprefixed Touch.rotationAngle to web. (Closed)

Created:
5 years, 6 months ago by mustaq
Modified:
5 years, 6 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Exposed unprefixed Touch.rotationAngle to web. Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KrokGpRH058/rQdIrSK5HM8J We have the prefixed version (webkitRotationAngle) available since M39. We will deprecate & eventually remove the prefixed versions of rotationAngle and three other attributes (radisuX, radiusY & force) afterwards. BUG=493199 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196186

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -89 lines) Patch
M LayoutTests/fast/events/touch/document-create-touch.html View 1 chunk +84 lines, -1 line 0 comments Download
M LayoutTests/fast/events/touch/document-create-touch-expected.txt View 4 chunks +13 lines, -9 lines 0 comments Download
D LayoutTests/fast/events/touch/script-tests/document-create-touch.js View 1 chunk +0 lines, -78 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Touch.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
mustaq
ptal.
5 years, 6 months ago (2015-05-29 15:49:28 UTC) #2
philipj_slow
LGTM, but wait to land until the blink-dev thread has one more LGTM. I started ...
5 years, 6 months ago (2015-05-29 16:58:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149233003/40001
5 years, 6 months ago (2015-05-30 03:43:42 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-05-30 05:02:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196186

Powered by Google App Engine
This is Rietveld 408576698