Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 114923012: Let perf dashboard track resources.pak instead of chrome.pak. (Closed)

Created:
6 years, 11 months ago by Nico
Modified:
6 years, 11 months ago
Reviewers:
cmp, tonyg
CC:
chromium-reviews, cmp-cc_chromium.org, e, jamesr, cmp
Visibility:
Public.

Description

Let perf dashboard track resources.pak instead of chrome.pak. All resources are in resources.pak these days, chrome.pak is an unused and mostly empty placeholder that will go away soon. BUG=52609 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=243049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M perf/dashboard/sizes.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 11 months ago (2013-12-31 22:07:33 UTC) #1
cmp
+tonyg Tony is the right person to review this or the right person to find ...
6 years, 11 months ago (2014-01-02 16:26:10 UTC) #2
tonyg
lgtm To clarify, this will only update the HTML page that shows the graph, it ...
6 years, 11 months ago (2014-01-05 21:26:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/114923012/1
6 years, 11 months ago (2014-01-06 01:41:18 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 01:41:23 UTC) #5
Message was sent while issue was closed.
Change committed as 243049

Powered by Google App Engine
This is Rietveld 408576698