Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Side by Side Diff: net/quic/quic_packet_creator_test.cc

Issue 114923007: Remove deprecated flag FLAGS_pad_quic_handshake_packets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/quic/quic_packet_creator.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_packet_creator.h" 5 #include "net/quic/quic_packet_creator.h"
6 6
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "net/quic/crypto/null_encrypter.h" 8 #include "net/quic/crypto/null_encrypter.h"
9 #include "net/quic/crypto/quic_decrypter.h" 9 #include "net/quic/crypto/quic_decrypter.h"
10 #include "net/quic/crypto/quic_encrypter.h" 10 #include "net/quic/crypto/quic_encrypter.h"
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 size_t expected_bytes_free = bytes_free < 3 ? 0 : bytes_free - 2; 367 size_t expected_bytes_free = bytes_free < 3 ? 0 : bytes_free - 2;
368 EXPECT_EQ(expected_bytes_free, creator_.BytesFree()) << "delta: " << delta; 368 EXPECT_EQ(expected_bytes_free, creator_.BytesFree()) << "delta: " << delta;
369 SerializedPacket serialized_packet = creator_.SerializePacket(); 369 SerializedPacket serialized_packet = creator_.SerializePacket();
370 ASSERT_TRUE(serialized_packet.packet); 370 ASSERT_TRUE(serialized_packet.packet);
371 delete serialized_packet.packet; 371 delete serialized_packet.packet;
372 delete serialized_packet.retransmittable_frames; 372 delete serialized_packet.retransmittable_frames;
373 } 373 }
374 } 374 }
375 375
376 TEST_F(QuicPacketCreatorTest, CryptoStreamFramePacketPadding) { 376 TEST_F(QuicPacketCreatorTest, CryptoStreamFramePacketPadding) {
377 ValueRestore<bool> old_flag(&FLAGS_pad_quic_handshake_packets, true);
378
379 // Compute the total overhead for a single frame in packet. 377 // Compute the total overhead for a single frame in packet.
380 const size_t overhead = GetPacketHeaderOverhead() + GetEncryptionOverhead() 378 const size_t overhead = GetPacketHeaderOverhead() + GetEncryptionOverhead()
381 + GetStreamFrameOverhead(); 379 + GetStreamFrameOverhead();
382 ASSERT_GT(kMaxPacketSize, overhead); 380 ASSERT_GT(kMaxPacketSize, overhead);
383 size_t capacity = kDefaultMaxPacketSize - overhead; 381 size_t capacity = kDefaultMaxPacketSize - overhead;
384 // Now, test various sizes around this size. 382 // Now, test various sizes around this size.
385 for (int delta = -5; delta <= 5; ++delta) { 383 for (int delta = -5; delta <= 5; ++delta) {
386 string data(capacity + delta, 'A'); 384 string data(capacity + delta, 'A');
387 size_t bytes_free = delta > 0 ? 0 : 0 - delta; 385 size_t bytes_free = delta > 0 ? 0 : 0 - delta;
388 386
(...skipping 12 matching lines...) Expand all
401 - bytes_free, serialized_packet.packet->length()); 399 - bytes_free, serialized_packet.packet->length());
402 } else { 400 } else {
403 EXPECT_EQ(client_framer_.GetMaxPlaintextSize(kDefaultMaxPacketSize), 401 EXPECT_EQ(client_framer_.GetMaxPlaintextSize(kDefaultMaxPacketSize),
404 serialized_packet.packet->length()); 402 serialized_packet.packet->length());
405 } 403 }
406 delete serialized_packet.packet; 404 delete serialized_packet.packet;
407 delete serialized_packet.retransmittable_frames; 405 delete serialized_packet.retransmittable_frames;
408 } 406 }
409 } 407 }
410 408
411
412 TEST_F(QuicPacketCreatorTest, NonCryptoStreamFramePacketNonPadding) { 409 TEST_F(QuicPacketCreatorTest, NonCryptoStreamFramePacketNonPadding) {
413 ValueRestore<bool> old_flag(&FLAGS_pad_quic_handshake_packets, true);
414
415 // Compute the total overhead for a single frame in packet. 410 // Compute the total overhead for a single frame in packet.
416 const size_t overhead = GetPacketHeaderOverhead() + GetEncryptionOverhead() 411 const size_t overhead = GetPacketHeaderOverhead() + GetEncryptionOverhead()
417 + GetStreamFrameOverhead(); 412 + GetStreamFrameOverhead();
418 ASSERT_GT(kDefaultMaxPacketSize, overhead); 413 ASSERT_GT(kDefaultMaxPacketSize, overhead);
419 size_t capacity = kDefaultMaxPacketSize - overhead; 414 size_t capacity = kDefaultMaxPacketSize - overhead;
420 // Now, test various sizes around this size. 415 // Now, test various sizes around this size.
421 for (int delta = -5; delta <= 5; ++delta) { 416 for (int delta = -5; delta <= 5; ++delta) {
422 string data(capacity + delta, 'A'); 417 string data(capacity + delta, 'A');
423 size_t bytes_free = delta > 0 ? 0 : 0 - delta; 418 size_t bytes_free = delta > 0 ? 0 : 0 - delta;
424 419
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 // After 64 calls, BoolSource will refresh the bucket - make sure it does. 640 // After 64 calls, BoolSource will refresh the bucket - make sure it does.
646 mock_random_.ChangeValue(); 641 mock_random_.ChangeValue();
647 } 642 }
648 643
649 delete frames_[0].stream_frame; 644 delete frames_[0].stream_frame;
650 } 645 }
651 646
652 } // namespace 647 } // namespace
653 } // namespace test 648 } // namespace test
654 } // namespace net 649 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_packet_creator.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698