Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 114923006: Some small changes to isolate handling in ddbg. (Closed)

Created:
7 years ago by turnidge
Modified:
7 years ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Some small changes to isolate handling in ddbg. - Whenever we hit a breakpoint or other interruption, change the current isolate. - The first isolate to pause is now the main isolate. (Instead of first created.) R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=31142

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -12 lines) Patch
M tools/ddbg.dart View 1 2 3 4 10 chunks +90 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
turnidge
7 years ago (2013-12-13 18:30:37 UTC) #1
hausner
lgtm
7 years ago (2013-12-13 18:41:40 UTC) #2
turnidge
On 2013/12/13 18:41:40, hausner wrote: > lgtm Added error checking for cases where there is ...
7 years ago (2013-12-13 18:58:39 UTC) #3
hausner
Still looks good to me.
7 years ago (2013-12-13 19:03:05 UTC) #4
turnidge
7 years ago (2013-12-13 19:13:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r31142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698