Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: base/memory/discardable_memory_win.cc

Issue 114923005: base: Discardable memory types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add missing include Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/memory/discardable_memory_win.cc
diff --git a/base/memory/discardable_memory_win.cc b/base/memory/discardable_memory_win.cc
index 92e39e5e7d421f3f7acd67ae39b7c9e95b060cd2..d0664bf3821118ee36e2cad36ddf584767b6a961 100644
--- a/base/memory/discardable_memory_win.cc
+++ b/base/memory/discardable_memory_win.cc
@@ -2,24 +2,37 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
willchan no longer on Chromium 2013/12/24 01:21:06 ditto here on including discardable_memory.h first
reveman 2013/12/26 11:46:08 Done.
+#include "base/logging.h"
#include "base/memory/discardable_memory_emulated.h"
namespace base {
// static
-bool DiscardableMemory::SupportedNatively() {
- return false;
+void DiscardableMemory::GetSupportedTypes(
+ std::vector<DiscardableMemoryType>* types) {
+ types->push_back(DISCARDABLE_MEMORY_TYPE_EMULATED);
}
// static
scoped_ptr<DiscardableMemory> DiscardableMemory::CreateLockedMemory(
size_t size) {
- scoped_ptr<internal::DiscardableMemoryEmulated> memory(
- new internal::DiscardableMemoryEmulated(size));
- if (!memory->Initialize())
- return scoped_ptr<DiscardableMemory>();
-
- return memory.PassAs<DiscardableMemory>();
+ switch (GetType()) {
+ case DISCARDABLE_MEMORY_TYPE_NONE:
+ case DISCARDABLE_MEMORY_TYPE_ANDROID:
+ case DISCARDABLE_MEMORY_TYPE_MAC:
+ return scoped_ptr<DiscardableMemory>();
+ case DISCARDABLE_MEMORY_TYPE_EMULATED: {
+ scoped_ptr<internal::DiscardableMemoryEmulated> memory(
+ new internal::DiscardableMemoryEmulated(size));
+ if (!memory->Initialize())
+ return scoped_ptr<DiscardableMemory>();
+
+ return memory.PassAs<DiscardableMemory>();
+ }
+ }
+
+ NOTREACHED();
+ return scoped_ptr<DiscardableMemory>();
}
// static

Powered by Google App Engine
This is Rietveld 408576698