base: Discardable memory types.

content/renderer/render_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_thread_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <vector>
@@ skipping 393 matching lines @@
   base::FilePath media_path;
   PathService::Get(DIR_MEDIA_LIBS, &media_path);
   if (!media_path.empty())
     media::InitializeMediaLibrary(media_path);
 
   memory_pressure_listener_.reset(new base::MemoryPressureListener(
       base::Bind(&RenderThreadImpl::OnMemoryPressure, base::Unretained(this))));
 
   renderer_process_id_ = base::kNullProcessId;
 
+  if (command_line.HasSwitch(switches::kUseDiscardableMemory)) {
+    std::string requested_type_name = command_line.GetSwitchValueASCII(
+        switches::kUseDiscardableMemory);
+    if (requested_type_name == "none") {

[Philippe, 2013/12/18 09:07:47]

Nit: I would remove the braces for consistency with the rest of the file.

[reveman, 2013/12/18 19:44:25]

I changed this a bit in latest patch by introducing type names to the
DiscardableMemory API. The reason I did this is that I think it's preferable to
keep those names close to the implementation and check in unit tests that all
types are named.

This code is now generating an error if the specified type is not supported.

PTAL.

+      base::DiscardableMemory::SetType(base::DISCARDABLE_MEMORY_TYPE_NONE);
+    } else if (requested_type_name == "android") {
+      base::DiscardableMemory::SetType(base::DISCARDABLE_MEMORY_TYPE_ANDROID);
+    } else if (requested_type_name == "mac") {
+      base::DiscardableMemory::SetType(base::DISCARDABLE_MEMORY_TYPE_MAC);
+    } else if (requested_type_name == "emulated") {
+      base::DiscardableMemory::SetType(base::DISCARDABLE_MEMORY_TYPE_EMULATED);
+    }
+  }
+
   // AllocateGpuMemoryBuffer must be used exclusively on one thread but
   // it doesn't have to be the same thread RenderThreadImpl is created on.
   allocate_gpu_memory_buffer_thread_checker_.DetachFromThread();
 
   TRACE_EVENT_END_ETW("RenderThreadImpl::Init", 0, "");
 }
 
 RenderThreadImpl::~RenderThreadImpl() {
 }
 
@@ skipping 935 matching lines @@
   if (!gamepad_shared_memory_reader_)
     gamepad_shared_memory_reader_.reset(new GamepadSharedMemoryReader);
   gamepad_shared_memory_reader_->SampleGamepads(*data);
 }
 
 base::ProcessId RenderThreadImpl::renderer_process_id() const {
   return renderer_process_id_;
 }
 
 }  // namespace content