Avoid basename conflict from memory_pressure_monitor.cc

Avoid basename conflict from memory_pressure_monitor.cc

This is a mechanical rename from subdirs into memory/ with _platform
suffixes instead. This avoids having duplicate basenames.

It would probably be better to have only
memory/memory_pressure_monitor.h and then _win.cc, _mac.cc, _chromeos.cc
implementations, but that's a more invasive change because of the
slightly different interfaces/members.

TBR=jam@chromium.org, oshima@chromium.org
R=thakis@chromium.org, chrisha@chromium.org
BUG=490824, gyp:384, 472772
Committed: https://crrev.com/dab3548020455128b116634d3bd5db327775c7ad
Cr-Commit-Position: refs/heads/master@{#331006}

[Nico, 2015-05-21 21:27:16]

lgtm, thanks! Should've pushed back more when this was added, sorry for causing
you work :-/

I added a bug to your BUG= line.

[scottmg, 2015-05-21 21:29:22]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2015-05-21 21:29:59]

scottmg@chromium.org changed reviewers:
+ jam@chromium.org, oshima@chromium.org

[commit-bot: I haz the power, 2015-05-21 21:30:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149223002/60001

[scottmg, 2015-05-21 21:30:40]

tbr oshima for #include change in chromeos/chromeos_switches.h
tbr jam for #include change in content/browser/browser_main_loop.cc

[chrisha, 2015-05-21 21:35:03]

The "probably better" solution you mention is what I plan on doing, but as you
pointed out needs a little more massaging.

Thanks for doing this. As Nico pointed out, more pushback on the original review
that created the base/win/memory_pressure_monitor (and the ensuing CL to make
other platforms *remove* the suffix) would have avoided this entirely. Mea
culpa.

[scottmg, 2015-05-21 21:37:58]

On 2015/05/21 21:35:03, chrisha wrote:
> The "probably better" solution you mention is what I plan on doing, but as you
> pointed out needs a little more massaging.
> 
> Thanks for doing this. As Nico pointed out, more pushback on the original
review
> that created the base/win/memory_pressure_monitor (and the ensuing CL to make
> other platforms *remove* the suffix) would have avoided this entirely. Mea
> culpa.

OK, thanks. Nothing like going in circles to pass the time! :)

[commit-bot: I haz the power, 2015-05-21 22:14:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-21 22:15:00]

Patchset 4 (id:??) landed as
https://crrev.com/dab3548020455128b116634d3bd5db327775c7ad
Cr-Commit-Position: refs/heads/master@{#331006}

[grt (UTC plus 2), 2015-05-22 14:03:39]

On 2015/05/21 21:35:03, chrisha wrote:
> The "probably better" solution you mention is what I plan on doing, but as you
> pointed out needs a little more massaging.
> 
> Thanks for doing this. As Nico pointed out, more pushback on the original
review
> that created the base/win/memory_pressure_monitor (and the ensuing CL to make
> other platforms *remove* the suffix) would have avoided this entirely. Mea
> culpa.

Apologies for suggesting something that ultimately caused problems.

[jabdelmalek, 2015-05-22 17:11:40]

I'm getting the following warnings when building with GN:

ninja: warning: multiple rules generate
obj/base/memory/memory.memory_pressure_monitor_win.obj. builds involving this
target will not be correct; cont
inuing anyway
ninja: Entering directory `out\Debug_gn'
[1/1] Regenerating ninja files
ninja: warning: multiple rules generate
obj/base/memory/memory.memory_pressure_monitor_win.obj. builds involving this
target will not be correct; cont
inuing anyway

Why is memory_pressure_monitor_win.cc listed twice in build.gn files?

[scottmg, 2015-05-22 19:37:41]

On 2015/05/22 17:11:40, jabdelmalek wrote:
> I'm getting the following warnings when building with GN:
> 
> ninja: warning: multiple rules generate
> obj/base/memory/memory.memory_pressure_monitor_win.obj. builds involving this
> target will not be correct; cont
> inuing anyway
> ninja: Entering directory `out\Debug_gn'
> [1/1] Regenerating ninja files
> ninja: warning: multiple rules generate
> obj/base/memory/memory.memory_pressure_monitor_win.obj. builds involving this
> target will not be correct; cont
> inuing anyway
> 
> Why is memory_pressure_monitor_win.cc listed twice in build.gn files?

Sorry, because I didn't test the GN build and that doesn't error out:
https://codereview.chromium.org/1150233003

[Nico, 2015-05-22 19:38:54]

On Fri, May 22, 2015 at 12:37 PM, <scottmg@chromium.org> wrote:

> On 2015/05/22 17:11:40, jabdelmalek wrote:
>
>> I'm getting the following warnings when building with GN:
>>
>
>  ninja: warning: multiple rules generate
>> obj/base/memory/memory.memory_pressure_monitor_win.obj. builds involving
>> this
>> target will not be correct; cont
>> inuing anyway
>> ninja: Entering directory `out\Debug_gn'
>> [1/1] Regenerating ninja files
>> ninja: warning: multiple rules generate
>> obj/base/memory/memory.memory_pressure_monitor_win.obj. builds involving
>> this
>> target will not be correct; cont
>> inuing anyway
>>
>
>  Why is memory_pressure_monitor_win.cc listed twice in build.gn files?
>>
>
> Sorry, because I didn't test the GN build and that doesn't error out:
> https://codereview.chromium.org/1150233003


(it will be possible to make this an error instead of a warning soon)


>
>
> https://codereview.chromium.org/1149223002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.