Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1149213005: Convert the ExtensionApiTest.AutotestPrivate test to use an event page instead of a background page (Closed)

Created:
5 years, 6 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert the ExtensionApiTest.AutotestPrivate test to use an event page instead of a background page This fixes timeouts caused by flipping the background pages to have throttled DOM timers R=kalman BUG=494815 Committed: https://crrev.com/16b8efce9a7b1d671ea89fd147e4e23d267a3786 Cr-Commit-Position: refs/heads/master@{#332688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/test/data/extensions/api_test/autotest_private/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
oystein (OOO til 10th of July)
one more for the road...
5 years, 6 months ago (2015-06-03 01:12:02 UTC) #1
not at google - send to devlin
lgtm
5 years, 6 months ago (2015-06-03 16:02:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149213005/1
5 years, 6 months ago (2015-06-03 16:10:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/13493)
5 years, 6 months ago (2015-06-03 18:10:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149213005/1
5 years, 6 months ago (2015-06-03 18:13:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/13559)
5 years, 6 months ago (2015-06-03 19:02:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149213005/1
5 years, 6 months ago (2015-06-03 20:04:15 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 21:27:17 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 21:28:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16b8efce9a7b1d671ea89fd147e4e23d267a3786
Cr-Commit-Position: refs/heads/master@{#332688}

Powered by Google App Engine
This is Rietveld 408576698