Don't update color in tabSwitcher Mode

chrome/android/java_staging/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.toolbar;
 
 import android.content.Context;
 import android.os.Handler;
 import android.os.Looper;
 import android.os.Message;
@@ skipping 622 matching lines @@
             mFullscreenManager.hideControlsPersistent(mFullscreenFocusToken);
             mFullscreenFocusToken = FullscreenManager.INVALID_TOKEN;
         }
     }
 
     /**
      * Update the primary color used by the model to the given color.
      * @param color The primary color for the current tab.
      */
     public void updatePrimaryColor(int color) {
-        boolean colorChanged = mToolbarModel.getPrimaryColor() != color;

[Ted C, 2015/05/26 18:44:35]

why did this need to be removed?

[Yusuf, 2015/05/26 18:57:23]

Changing this flow so that we now always get color pushed to the toolbar even if
the color doesn't change. That is why I wanted to rename it to reflect the
possibility of the color actually not changing.

Toolbar gets to decide whether it needs to early return or do something else.
This is to support the model being updated whenever the color changes, but this
getting reflected in the UI only when visual state changes. Say we are in
tabswitcher mode and the user selected a colored page. We update the model, but
this doesn't change the color of the toolbar. Then on refreshSelectedTab when we
switch out of tabswitcher, we check it again and transition if necessary.

Or we can find a way to handle all this in toolbar where it always does
something similar calling onPrimaryColorChanged for
updateVisualsForToolbarState.

[Yusuf, 2015/05/26 20:43:19]

Removed all the changes related with this since they were not necessary for the
fix. Just kept the bit in the toolbar phone update.

-        if (!colorChanged) return;
-
         mToolbarModel.setPrimaryColor(color);
-        mToolbar.onPrimaryColorChanged();

[Ted C, 2015/05/26 18:44:35]

I think the previous name was clearer and more consistent.  It is up to the
toolbar to act on signals from the manager, and it is fine for one to ignore an
update.  There are other places that do this and the naming for them is more
along the lines of updateBlah or onBlahChanged, so creating a new naming scheme
seems to add more mental confusion than necessary.

+        mToolbar.checkPrimaryColorTransition();
     }
 
     /**
      * Updates the current number of Tabs based on the TabModel this Toolbar contains.
      */
     private void updateTabCount() {
         if (!mTabRestoreCompleted) return;
         mToolbar.updateTabCountVisuals(mTabModelSelector.getCurrentModel().getCount());
     }
 
@@ skipping 194 matching lines @@
         }
 
         /**
          * Cancels simulating load progress.
          */
         public void cancel() {
             mHandler.removeMessages(MSG_ID_UPDATE_PROGRESS);
         }
     }
 }