Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1149203003: Revert of Implement SharedArrayBuffer (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement SharedArrayBuffer (patchset #7 id:120001 of https://codereview.chromium.org/1136553006/) Reason for revert: breaks build Original issue's description: > Implement SharedArrayBuffer. > > This adds a new external type (v8::SharedArrayBuffer) that uses a JSArrayBuffer under the hood. It can be distinguished from an ArrayBuffer by the newly-added is_shared() bit. > > Currently there is no difference in functionality between a SharedArrayBuffer and an ArrayBuffer. However, a future CL will add the Atomics API, which is only available on an SharedArrayBuffer. All non-atomic accesses are identical to ArrayBuffer accesses. > > BUG= > > Committed: https://crrev.com/57170bff7baf341c666252a7f6a49e9c08d51263 > Cr-Commit-Position: refs/heads/master@{#28588} TBR=jarin@chromium.org,jochen@chromium.org,binji@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/57ee3c0f6eea835cfb094fd39cd1883ea4d6e33f Cr-Commit-Position: refs/heads/master@{#28589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1047 lines) Patch
M BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M include/v8.h View 5 chunks +2 lines, -116 lines 0 comments Download
M src/api.h View 3 chunks +0 lines, -5 lines 0 comments Download
M src/api.cc View 8 chunks +6 lines, -83 lines 0 comments Download
M src/arraybuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -2 lines 0 comments Download
D src/harmony-sharedarraybuffer.js View 1 chunk +0 lines, -56 lines 0 comments Download
M src/macros.py View 2 chunks +0 lines, -5 lines 0 comments Download
M src/objects.h View 3 chunks +0 lines, -8 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +7 lines, -8 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 8 chunks +8 lines, -16 lines 0 comments Download
M src/typedarray.js View 2 chunks +1 line, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D test/mjsunit/harmony/sharedarraybuffer.js View 1 chunk +0 lines, -576 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Implement SharedArrayBuffer
5 years, 7 months ago (2015-05-22 12:17:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149203003/1
5 years, 7 months ago (2015-05-22 12:17:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 12:18:18 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 12:18:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57ee3c0f6eea835cfb094fd39cd1883ea4d6e33f
Cr-Commit-Position: refs/heads/master@{#28589}

Powered by Google App Engine
This is Rietveld 408576698