sdk/lib/_internal/compiler/implementation/native_handler.dart - Issue 11492006: Minify methods, classes and fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/native_handler.dart

Issue 11492006: Minify methods, classes and fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Responses to Nicolas' late comments and restore missing '!' from last commit. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/native_handler.dart

diff --git a/sdk/lib/_internal/compiler/implementation/native_handler.dart b/sdk/lib/_internal/compiler/implementation/native_handler.dart

index 825069e70f3d51f76239e9295df207e321ad28eb..9ab2ed571eefd6cf1115374c013e09551bac57ef 100644

--- a/sdk/lib/_internal/compiler/implementation/native_handler.dart

+++ b/sdk/lib/_internal/compiler/implementation/native_handler.dart

@@ -823,11 +823,11 @@ void handleSsaNative(SsaBuilder builder, Expression nativeBody) {

// Check which pattern this native method follows:

// 1) foo() native;

- // hasBody = false, isRedirecting = false

+ // hasBody = false

// 2) foo() native "bar";

- // hasBody = false, isRedirecting = true, no longer supported.

+ // No longer supported, this is now done with @JSName('foo') and case 1.

// 3) foo() native "return 42";

- // hasBody = true, isRedirecting = false

+ // hasBody = true

bool hasBody = false;

assert(element.isNative());

String nativeMethodName = element.nativeName();