sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart - Issue 11492006: Minify methods, classes and fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

Issue 11492006: Minify methods, classes and fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Responses to Nicolas' late comments and restore missing '!' from last commit. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

index c5a85ca40257650227bea9c3424ad17011e47067..86717aed749ec162fc5a31a50342a8ffb065f2f8 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

@@ -131,11 +131,11 @@ class ConstantReferenceEmitter implements ConstantVisitor<js.Expression> {

js.Expression emitCanonicalVersion(Constant constant) {

String name = namer.constantName(constant);

if (inIsolateInitializationContext) {

- // $ISOLATE.$ISOLATE_PROPERTIES.$name

+ // $isolateName.$isolatePropertiesName.$name

return new js.PropertyAccess.field(

new js.PropertyAccess.field(

- new js.VariableUse(namer.ISOLATE),

- namer.ISOLATE_PROPERTIES),

+ new js.VariableUse(namer.isolateName),

+ namer.isolatePropertiesName),

name);

} else {

return new js.PropertyAccess.field(

@@ -222,7 +222,7 @@ class ConstantInitializerEmitter implements ConstantVisitor<js.Expression> {

js.Expression visitList(ListConstant constant) {

return new js.Call(

new js.PropertyAccess.field(

- new js.VariableUse(namer.ISOLATE),

+ new js.VariableUse(namer.isolateName),

'makeConstantList'),

[new js.ArrayInitializer.from(_array(constant.entries))]);

}