Issue 1149163004: Revert "Add Client Attribute to FetchEvent- Blink Side."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1149163004: Revert "Add Client Attribute to FetchEvent- Blink Side." (Closed)

Created:
4 years, 11 months ago by falken

Modified:
4 years, 11 months ago

Reviewers:
Paritosh Kumar

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert "Add Client Attribute to FetchEvent- Blink Side." This reverts commit c338ecfe4d2879295bb240a6441b93882485ce96. Reverting since the Chromium-side change isn't ready. We can reland when it's ready. BUG=495901, 470036 TBR=paritosh.in@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196368

Patch Set 1 #

Patch Set 2 : fix merge #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -36 lines)			Patch
M	Source/modules/serviceworkers/FetchEvent.h	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/modules/serviceworkers/FetchEvent.cpp	View	1	3 chunks	+0 lines, -8 lines	0 comments	Download
M	Source/modules/serviceworkers/FetchEvent.idl	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/serviceworkers/FetchEventInit.idl	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/platform/exported/WebServiceWorkerRequest.cpp	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	Source/web/ServiceWorkerGlobalScopeProxy.cpp	View		2 chunks	+1 line, -8 lines	0 comments	Download
M	public/platform/WebServiceWorkerRequest.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149163004/20001

4 years, 11 months ago (2015-06-03 01:17:15 UTC) #4

commit-bot: I haz the power

4 years, 11 months ago (2015-06-03 04:55:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196368

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages