ash/wm/dock/docked_window_layout_manager.cc - Issue 1149153007: Ignores programmatic bounds changes for docked windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/dock/docked_window_layout_manager.cc

Issue 1149153007: Ignores programmatic bounds changes for docked windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ignores programmatic bounds changes for docked windows (test) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/dock/docked_window_layout_manager.cc

diff --git a/ash/wm/dock/docked_window_layout_manager.cc b/ash/wm/dock/docked_window_layout_manager.cc

index 91fe6c83ab798a45f4560b725463bf5d9ffe2bfe..d12d21741f7be4e5e1e969e6a47edcc8592af377 100644

--- a/ash/wm/dock/docked_window_layout_manager.cc

+++ b/ash/wm/dock/docked_window_layout_manager.cc

@@ -745,6 +745,8 @@ void DockedWindowLayoutManager::SetChildBounds(

actual_new_bounds.set_height(

std::max(min_size.height(), actual_new_bounds.height()));

}

+ if (IsUsedByLayout(child) && child != dragged_window_)

oshima 2015/06/04 22:40:29 doesn't this prevent relayouting docked windows up

varkha 2015/06/04 23:22:00 No. Display change is handled in OnWindowResized()

+ return;

SnapToPixelLayoutManager::SetChildBounds(child, actual_new_bounds);

if (IsPopupOrTransient(child))

return;

« no previous file with comments | « no previous file | ash/wm/dock/docked_window_layout_manager_unittest.cc » ('j') | no next file with comments »