Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1149143002: Merge M43: Enable appcontainer on M43 (Closed)

Created:
5 years, 7 months ago by Will Harris
Modified:
5 years, 7 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, rickyz+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

Merge M43: Enable appcontainer on M43 Reverted appcontainer mini-dump creation. As we would have received sufficient crash reports for analysis, reverting. BUG=468922, 473715, 455496 R=cpu@chromium.org, jschuh@chromium.org, cpu, wfh Review URL: https://codereview.chromium.org/1077913002 Cr-Commit-Position: refs/heads/master@{#324566} (cherry picked from commit 55c2f2365e41a170f37ed56d13ced4ef054abffa) Adding minidump creation when launching renderer process fails in appcontainer mode. Also reenabled appcontainer for renderer and fixed policy use after free case. BUG=468922, 473715, 455496 Review URL: https://codereview.chromium.org/1058373003 Cr-Commit-Position: refs/heads/master@{#324348} (cherry picked from commit 9203ef8157d4d47970dd0255d7de009697618bb2) Committed: https://chromium.googlesource.com/chromium/src/+/638956dafee998e7fd761afdd052959b01ad3bc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M content/common/sandbox_win.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
laforge
lgtm
5 years, 7 months ago (2015-05-21 19:59:25 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-05-21 20:43:56 UTC) #4
cpu_(ooo_6.6-7.5)
don't we need the vs debugger (forshaw) fix?
5 years, 7 months ago (2015-05-21 20:46:23 UTC) #5
Will Harris
On 2015/05/21 20:46:23, cpu wrote: > don't we need the vs debugger (forshaw) fix? people ...
5 years, 7 months ago (2015-05-21 20:47:35 UTC) #6
Will Harris
5 years, 7 months ago (2015-05-21 21:04:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
638956dafee998e7fd761afdd052959b01ad3bc7.

Powered by Google App Engine
This is Rietveld 408576698