Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1149133003: Substituting pattern ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in src/ash/ (Closed)

Created:
5 years, 7 months ago by d.samantaray
Modified:
5 years, 7 months ago
Reviewers:
Daniel Erat, oshima
CC:
chromium-reviews, sadrul, tdanderson+overview_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Substituting pattern push_back(ptr.release()) with push_back(ptr.Pass()) in src/ash/ BUG=457697 Committed: https://crrev.com/179dc33d89dcaa0847f7f85e57d6a946e5ed4726 Cr-Commit-Position: refs/heads/master@{#331522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
d.samantaray
Uploaded the patch , please review
5 years, 7 months ago (2015-05-25 09:31:19 UTC) #2
Daniel Erat
lgtm
5 years, 7 months ago (2015-05-26 13:56:02 UTC) #3
oshima
lgtm
5 years, 7 months ago (2015-05-26 22:21:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149133003/1
5 years, 7 months ago (2015-05-27 03:22:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 04:06:57 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 04:07:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/179dc33d89dcaa0847f7f85e57d6a946e5ed4726
Cr-Commit-Position: refs/heads/master@{#331522}

Powered by Google App Engine
This is Rietveld 408576698