Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1149113006: Move Pickle to base namespace. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
jschuh, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, gavinp+disk_chromium.org, vabr+watchlist_chromium.org, browser-components-watch_chromium.org, dcheng, noyau+watch_chromium.org, piman+watch_chromium.org, markusheintz_, jdduke+watch_chromium.org, tapted, cbentzel+watch_chromium.org, Matt Giuca, grt+watch_chromium.org, lcwu+watch_chromium.org, chromoting-reviews_chromium.org, jam, ben+mojo_chromium.org, abarth-chromium, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, dgrogan, extensions-reviews_chromium.org, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, yzshen+watch_chromium.org, asvitkine+watch_chromium.org, gunsch+watch_chromium.org, gcasto+watchlist_chromium.org, jsbell+idb_chromium.org, darin (slow to review), rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, tfarina, Aaron Boodman, cmumford, estade+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Pickle to base namespace. Updates forward-declares and headers, but keeps a using statement in to avoid updating all users atomically. TBR=jschuh for IPC stuff Committed: https://crrev.com/05cfd8ddb3849b7e11bb53e199064291a52aeea9 Cr-Commit-Position: refs/heads/master@{#332352}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+523 lines, -412 lines) Patch
M android_webview/native/state_serializer.h View 1 2 3 2 chunks +11 lines, -6 lines 0 comments Download
M base/files/file_path.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/metrics/histogram.h View 7 chunks +13 lines, -14 lines 0 comments Download
M base/metrics/histogram_base.h View 4 chunks +6 lines, -7 lines 0 comments Download
M base/metrics/histogram_samples.h View 1 chunk +2 lines, -3 lines 0 comments Download
M base/metrics/sparse_histogram.h View 1 chunk +4 lines, -4 lines 0 comments Download
M base/pickle.h View 4 chunks +13 lines, -5 lines 0 comments Download
M base/pickle_unittest.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M base/posix/unix_domain_socket_linux.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/fast_show_pickler.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_drag_data.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_drag_data.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/content_settings_pattern_serializer.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/safe_browsing/ipc_protobuf_message_macros.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/safe_browsing/protobuf_message_param_traits.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/safe_browsing/protobuf_message_read_macros.h View 3 chunks +17 lines, -12 lines 0 comments Download
M chromecast/common/media/cma_param_traits.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/common/form_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/common/form_field_data.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data.h View 3 chunks +7 lines, -4 lines 0 comments Download
M components/nacl/browser/nacl_validation_cache.h View 3 chunks +5 lines, -3 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M components/network_hints/common/network_hints_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/serialized_navigation_entry.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sessions/session_command.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/npruntime_util.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/child/plugin_param_traits.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/android/gin_java_bridge_value.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/cc_messages.h View 9 chunks +9 lines, -9 lines 0 comments Download
M content/common/content_param_traits.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/cursors/webcursor.h View 3 chunks +6 lines, -4 lines 0 comments Download
M content/common/cursors/webcursor_android.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/cursors/webcursor_aurawin.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/cursors/webcursor_aurax11.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/cursors/webcursor_mac.mm View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/cursors/webcursor_ozone.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/cursors/webcursor_unittest.cc View 1 11 chunks +18 lines, -18 lines 0 comments Download
M content/common/gamepad_param_traits.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/indexed_db/indexed_db_param_traits.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/input/input_param_traits.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/mac/attributed_string_coder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/media/media_param_traits.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/resource_messages.h View 5 chunks +5 lines, -5 lines 0 comments Download
M content/public/common/common_param_traits.h View 1 7 chunks +9 lines, -7 lines 0 comments Download
M content/zygote/zygote_linux.h View 5 chunks +7 lines, -5 lines 0 comments Download
M crypto/secure_hash.h View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/common/extension_messages.h View 8 chunks +8 lines, -8 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/manifest_permission.h View 2 chunks +3 lines, -4 lines 0 comments Download
M extensions/common/permissions/set_disjunction_permission.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/settings_override_permission.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/user_script.h View 1 3 chunks +18 lines, -13 lines 0 comments Download
M extensions/common/user_script.cc View 9 chunks +19 lines, -14 lines 0 comments Download
M gpu/ipc/gpu_command_buffer_traits.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_message_utils.h View 45 chunks +61 lines, -46 lines 0 comments Download
M ipc/ipc_message_utils_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_sync_message.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_mojo_message_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_mojo_param_traits.h View 2 chunks +3 lines, -1 line 0 comments Download
M ipc/param_traits_macros.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ipc/param_traits_read_macros.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/io_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/signed_certificate_timestamp.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/cert/x509_certificate.h View 4 chunks +8 lines, -4 lines 0 comments Download
M net/cert/x509_util_nss.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/disk_cache/simple/simple_index.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_index_file.h View 5 chunks +7 lines, -6 lines 0 comments Download
M net/http/http_response_headers.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/http/http_response_info.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/http/http_vary_data.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/ssl/ssl_info.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/proxy/ppapi_message_utils.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 18 chunks +18 lines, -18 lines 0 comments Download
M ppapi/proxy/raw_var_data.h View 9 chunks +11 lines, -8 lines 0 comments Download
M ppapi/proxy/resource_message_params.h View 5 chunks +11 lines, -7 lines 0 comments Download
M ppapi/proxy/serialized_flash_menu.h View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/proxy/serialized_handle.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/proxy/serialized_structs.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/serialized_var.h View 3 chunks +4 lines, -2 lines 0 comments Download
M remoting/host/chromoting_param_traits.h View 5 chunks +5 lines, -5 lines 0 comments Download
M skia/ext/skia_utils_base.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/clipboard/clipboard_test_template.h View 6 chunks +10 lines, -10 lines 0 comments Download
M ui/base/clipboard/custom_data_helper.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/base/clipboard/scoped_clipboard_writer.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data.h View 5 chunks +7 lines, -4 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aura.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/ipc/gfx_param_traits.h View 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 33 (17 generated)
brettw
5 years, 6 months ago (2015-06-01 18:27:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149113006/1
5 years, 6 months ago (2015-06-01 18:29:50 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/67229)
5 years, 6 months ago (2015-06-01 19:06:08 UTC) #6
sky
Rubber stamp LGTM
5 years, 6 months ago (2015-06-01 19:14:53 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149113006/20001
5 years, 6 months ago (2015-06-01 19:16:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149113006/20001
5 years, 6 months ago (2015-06-01 19:22:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/67250)
5 years, 6 months ago (2015-06-01 19:32:22 UTC) #14
brettw
5 years, 6 months ago (2015-06-01 19:59:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149113006/40001
5 years, 6 months ago (2015-06-01 20:03:05 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/28492)
5 years, 6 months ago (2015-06-01 21:27:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149113006/60001
5 years, 6 months ago (2015-06-01 21:34:19 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/28549)
5 years, 6 months ago (2015-06-02 00:59:43 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149113006/60001
5 years, 6 months ago (2015-06-02 04:22:35 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149113006/60001
5 years, 6 months ago (2015-06-02 05:46:53 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-02 07:02:58 UTC) #32
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 07:03:55 UTC) #33
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/05cfd8ddb3849b7e11bb53e199064291a52aeea9
Cr-Commit-Position: refs/heads/master@{#332352}

Powered by Google App Engine
This is Rietveld 408576698