cc/damage_tracker_unittest.cc - Issue 11491007: cc: Remove dangerous LayerImpl::removeFromParent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/damage_tracker_unittest.cc

Issue 11491007: cc: Remove dangerous LayerImpl::removeFromParent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/damage_tracker_unittest.cc

diff --git a/cc/damage_tracker_unittest.cc b/cc/damage_tracker_unittest.cc

index 88cd441a844de0711d507742d8902f8363e3e0f3..aec754b7e8e04552a6c5b8d52a39615e5f320b7d 100644

--- a/cc/damage_tracker_unittest.cc

+++ b/cc/damage_tracker_unittest.cc

@@ -561,7 +561,8 @@ TEST_F(DamageTrackerTest, verifyDamageForAddingAndRemovingLayer)

EXPECT_TRUE(root->renderSurface()->damageTracker()->currentDamageRect().IsEmpty());

// Then, test removing child1.

- child1->removeFromParent();

+ root->removeChild(child1);

+ child1 = NULL;

emulateDrawingOneFrame(root.get());

rootDamageRect = root->renderSurface()->damageTracker()->currentDamageRect();

EXPECT_FLOAT_RECT_EQ(gfx::RectF(100, 100, 30, 30), rootDamageRect);

« no previous file with comments | « no previous file | cc/layer_impl.h » ('j') | cc/layer_impl.cc » ('J')