Issue 11491005: Fix for Issue 7224

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11491005: Fix for Issue 7224 (Closed)

Created:
8 years ago by sra1

Modified:
8 years ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, erikcorry

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for Issue 7224 Submitted as part of r15886

Patch Set 1 #

Total comments: 3

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		3 chunks	+10 lines, -2 lines	3 comments	Download
	M	sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years ago (2012-12-09 10:41:50 UTC) #2

LGTM

https://codereview.chromium.org/11491005/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/11491005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:220: '''/* Get
the superclass and the fields in the format Super;field1,field2 from
Update the comment?

https://codereview.chromium.org/11491005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:222: var
fields = desc[''], supr = desc['super'];
why not put "supr = desc['super']" in an else branch?

https://codereview.chromium.org/11491005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:223: if
(typeof fields=='string') {
spaces between '=='

Expand Messages | Collapse Messages