Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: cc/layer_tree_host_impl.h

Issue 11491003: Revert 171714 - Use an auxiliary list of animation controllers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layer_tree_host_common_unittest.cc ('k') | cc/layer_tree_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layer_tree_host_impl.h
diff --git a/cc/layer_tree_host_impl.h b/cc/layer_tree_host_impl.h
index 1babd36acee12d7194e81841dcac715984f070e7..71049a8f9ea599b5f7e72b9ac09db3685c9bf728 100644
--- a/cc/layer_tree_host_impl.h
+++ b/cc/layer_tree_host_impl.h
@@ -9,7 +9,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/time.h"
#include "cc/animation_events.h"
-#include "cc/animation_registrar.h"
#include "cc/cc_export.h"
#include "cc/input_handler.h"
#include "cc/layer_tree_impl.h"
@@ -114,10 +113,8 @@ class CC_EXPORT LayerTreeHostImpl : public InputHandlerClient,
public RendererClient,
public TileManagerClient,
public LayerTreeImplClient,
- public AnimationRegistrar,
public OutputSurfaceClient {
typedef std::vector<LayerImpl*> LayerList;
- typedef base::hash_set<LayerAnimationController*> AnimationControllerSet;
public:
static scoped_ptr<LayerTreeHostImpl> create(const LayerTreeSettings&, LayerTreeHostImplClient*, Proxy*);
@@ -248,7 +245,9 @@ public:
bool hasTransparentBackground() const { return m_hasTransparentBackground; }
void setHasTransparentBackground(bool transparent) { m_hasTransparentBackground = transparent; }
- bool needsAnimateLayers() const { return !m_activeAnimationControllers.empty(); }
+
+ bool needsAnimateLayers() const { return m_needsAnimateLayers; }
+ void setNeedsAnimateLayers() { m_needsAnimateLayers = true; }
void setNeedsRedraw();
@@ -343,14 +342,7 @@ private:
void dumpRenderSurfaces(std::string*, int indent, const LayerImpl*) const;
- // AnimationRegistar implementation.
- virtual void DidActivateAnimationController(LayerAnimationController*) OVERRIDE;
- virtual void DidDeactivateAnimationController(LayerAnimationController*) OVERRIDE;
- virtual void RegisterAnimationController(LayerAnimationController*) OVERRIDE;
- virtual void UnregisterAnimationController(LayerAnimationController*) OVERRIDE;
-
scoped_ptr<OutputSurface> m_outputSurface;
-
scoped_ptr<ResourceProvider> m_resourceProvider;
scoped_ptr<Renderer> m_renderer;
scoped_ptr<TileManager> m_tileManager;
@@ -371,6 +363,7 @@ private:
bool m_hasTransparentBackground;
// If this is true, it is necessary to traverse the layer tree ticking the animators.
+ bool m_needsAnimateLayers;
bool m_pinchGestureActive;
gfx::Point m_previousPinchAnchor;
@@ -395,12 +388,6 @@ private:
int64 m_cumulativeNumMissingTiles;
- AnimationControllerSet m_activeAnimationControllers;
-
-#if !defined(NDEBUG)
- AnimationControllerSet m_allAnimationControllers;
-#endif
-
size_t m_lastSentMemoryVisibleBytes;
size_t m_lastSentMemoryVisibleAndNearbyBytes;
size_t m_lastSentMemoryUseBytes;
« no previous file with comments | « cc/layer_tree_host_common_unittest.cc ('k') | cc/layer_tree_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698