Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2264)

Unified Diff: Source/web/ChromeClientImpl.h

Issue 1149093010: Cleanup: Rename ChromeClient function names. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ChromeClientImpl.h
diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h
index 225ed52854c8a7bfef9acf0e3b4c18474ad7be11..2dff4458910b2f5fbcc97bb6b535156899e9e966 100644
--- a/Source/web/ChromeClientImpl.h
+++ b/Source/web/ChromeClientImpl.h
@@ -79,12 +79,12 @@ public:
LocalFrame*, MessageSource, MessageLevel,
const String& message, unsigned lineNumber,
const String& sourceID, const String& stackTrace) override;
- bool canRunBeforeUnloadConfirmPanel() override;
- bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String&) override;
+ bool canOpenBeforeUnloadConfirmPanel() override;
+ bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, const String&) override;
void closeWindowSoon() override;
- void runJavaScriptAlertInternal(LocalFrame*, const String&) override;
- bool runJavaScriptConfirmInternal(LocalFrame*, const String&) override;
- bool runJavaScriptPromptInternal(
+ void openJavaScriptAlertDelegate(LocalFrame*, const String&) override;
+ bool openJavaScriptConfirmDelegate(LocalFrame*, const String&) override;
+ bool openJavaScriptPromptDelegate(
LocalFrame*, const String& message,
const String& defaultValue, String& result) override;
void setStatusbarText(const String& message) override;
@@ -102,11 +102,11 @@ public:
void showMouseOverURL(const HitTestResult&) override;
void setToolTip(const String& tooltipText, TextDirection) override;
void dispatchViewportPropertiesDidChange(const ViewportDescription&) const override;
- void printInternal(LocalFrame*) override;
+ void printDelegate(LocalFrame*) override;
void annotatedRegionsChanged() override;
- PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color&) override;
+ PassOwnPtrWillBeRawPtr<ColorChooser> openColorChooser(LocalFrame*, ColorChooserClient*, const Color&) override;
PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) override;
- void runOpenPanel(LocalFrame*, PassRefPtr<FileChooser>) override;
+ void openFileChooser(LocalFrame*, PassRefPtr<FileChooser>) override;
void enumerateChosenDirectory(FileChooser*) override;
void setCursor(const Cursor&) override;
Cursor lastSetCursorForTesting() const override;
@@ -136,12 +136,12 @@ public:
void setNewWindowNavigationPolicy(WebNavigationPolicy);
bool hasOpenedPopup() const override;
- PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) override;
+ PassRefPtrWillBeRawPtr<PopupMenu> openPopupMenu(LocalFrame&, PopupMenuClient*) override;
PagePopup* openPagePopup(PagePopupClient*);
void closePagePopup(PagePopup*);
DOMWindow* pagePopupWindowForTesting() const override;
- bool shouldRunModalDialogDuringPageDismissal(const DialogType&, const String& dialogMessage, Document::PageDismissalType) const override;
+ bool shouldOpenModalDialogDuringPageDismissal(const DialogType&, const String& dialogMessage, Document::PageDismissalType) const override;
bool requestPointerLock() override;
void requestPointerUnlock() override;
« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698