Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: Source/core/loader/EmptyClients.h

Issue 1149093010: Cleanup: Rename ChromeClient function names. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutMenuList.cpp ('k') | Source/core/loader/EmptyClients.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/EmptyClients.h
diff --git a/Source/core/loader/EmptyClients.h b/Source/core/loader/EmptyClients.h
index 2f7c8f736cb180341b0bbdeb211ec43d269a8b36..2089427b2f5a589d3d510f52216790dac97f1aff 100644
--- a/Source/core/loader/EmptyClients.h
+++ b/Source/core/loader/EmptyClients.h
@@ -102,17 +102,17 @@ public:
bool shouldReportDetailedMessageForSource(LocalFrame&, const String&) override { return false; }
void addMessageToConsole(LocalFrame*, MessageSource, MessageLevel, const String&, unsigned, const String&, const String&) override { }
- bool canRunBeforeUnloadConfirmPanel() override { return false; }
- bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String&) override { return true; }
+ bool canOpenBeforeUnloadConfirmPanel() override { return false; }
+ bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, const String&) override { return true; }
void closeWindowSoon() override { }
- void runJavaScriptAlertInternal(LocalFrame*, const String&) override { }
- bool runJavaScriptConfirmInternal(LocalFrame*, const String&) override { return false; }
- bool runJavaScriptPromptInternal(LocalFrame*, const String&, const String&, String&) override { return false; }
+ void openJavaScriptAlertDelegate(LocalFrame*, const String&) override { }
+ bool openJavaScriptConfirmDelegate(LocalFrame*, const String&) override { return false; }
+ bool openJavaScriptPromptDelegate(LocalFrame*, const String&, const String&, String&) override { return false; }
bool hasOpenedPopup() const override { return false; }
- PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) override;
+ PassRefPtrWillBeRawPtr<PopupMenu> openPopupMenu(LocalFrame&, PopupMenuClient*) override;
DOMWindow* pagePopupWindowForTesting() const override { return nullptr; }
void setStatusbarText(const String&) override { }
@@ -132,15 +132,15 @@ public:
void setToolTip(const String&, TextDirection) override { }
- void printInternal(LocalFrame*) override { }
+ void printDelegate(LocalFrame*) override { }
void enumerateChosenDirectory(FileChooser*) override { }
- PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color&) override;
+ PassOwnPtrWillBeRawPtr<ColorChooser> openColorChooser(LocalFrame*, ColorChooserClient*, const Color&) override;
PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) override;
void openTextDataListChooser(HTMLInputElement&) override;
- void runOpenPanel(LocalFrame*, PassRefPtr<FileChooser>) override;
+ void openFileChooser(LocalFrame*, PassRefPtr<FileChooser>) override;
void setCursor(const Cursor&) override { }
Cursor lastSetCursorForTesting() const override { return pointerCursor(); }
« no previous file with comments | « Source/core/layout/LayoutMenuList.cpp ('k') | Source/core/loader/EmptyClients.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698