Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149093010: Cleanup: Rename ChromeClient function names. (Closed)

Created:
5 years, 6 months ago by tkent
Modified:
5 years, 6 months ago
Reviewers:
keishi, yosin_UTC9
CC:
blink-reviews, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, szager+layoutwatch_chromium.org, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, gavinp+loader_chromium.org, jchaffraix+rendering, pdr+renderingwatchlist_chromium.org, Nate Chapin, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cleanup: Rename ChromeClient function names. * canRunBeforeUnloadConfirmPanel -> canOpenBeforeUnloadConfirmPanel * runBeforeUnloadConfirmPanel -> openBeforeUnloadConfirmPanel * runJavaScript* -> openJavaScript* * runJavaScript*Internal -> openJavaScript*Delegate * createColorChooser -> openColorChooser * runOpenPanel -> openFileChooser * createPopupMenu -> openPopupMenu * shouldRunModalDialogDuringPageDismissal -> shouldOpenModalDialogDuringPageDismissal * printInternal -> printDelegate fooDelegate is a common naming for this pattern in Chromium. BUG=495378 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -74 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/ColorInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutMenuList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/loader/EmptyClients.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 6 chunks +15 lines, -18 lines 0 comments Download
M Source/core/page/ChromeClient.cpp View 3 chunks +14 lines, -14 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 8 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
yosin@ or keishi@, please review this.
5 years, 6 months ago (2015-06-04 05:54:16 UTC) #2
yosin_UTC9
lgtm Thanks for intuitive names!
5 years, 6 months ago (2015-06-04 05:56:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149093010/1
5 years, 6 months ago (2015-06-04 05:56:55 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 06:11:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196463

Powered by Google App Engine
This is Rietveld 408576698