net/quic/crypto/channel_id_chromium.cc - Issue 1149083013: Combine ChannelIDService::RequestHandle and ChannelIDServiceRequest classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/channel_id_chromium.cc

Issue 1149083013: Combine ChannelIDService::RequestHandle and ChannelIDServiceRequest classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ChannelIDService::Request::Cancel() now deletes ptr to Request from ChannelIDServiceJob Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/crypto/channel_id_chromium.cc

diff --git a/net/quic/crypto/channel_id_chromium.cc b/net/quic/crypto/channel_id_chromium.cc

index 9a54e88a6864d2a0ad10abed4ca7e40313e3e12b..ab50efa8e1f79ff9f897e2842fac3e319b89fabe 100644

--- a/net/quic/crypto/channel_id_chromium.cc

+++ b/net/quic/crypto/channel_id_chromium.cc

@@ -89,7 +89,7 @@ class ChannelIDSourceChromium::Job {

ChannelIDService* const channel_id_service_;

scoped_ptr<crypto::ECPrivateKey> channel_id_crypto_key_;

- ChannelIDService::RequestHandle channel_id_request_handle_;

+ ChannelIDService::Request channel_id_request_;

// |hostname| specifies the hostname for which we need a channel ID.

std::string hostname_;

@@ -181,7 +181,7 @@ int ChannelIDSourceChromium::Job::DoGetChannelIDKey(int result) {

hostname_, &channel_id_crypto_key_,

base::Bind(&ChannelIDSourceChromium::Job::OnIOComplete,

base::Unretained(this)),

- &channel_id_request_handle_);

+ &channel_id_request_);

}

int ChannelIDSourceChromium::Job::DoGetChannelIDKeyComplete(int result) {

« no previous file with comments | « chrome/browser/extensions/extension_messages_apitest.cc ('k') | net/socket/ssl_client_socket_nss.cc » ('j') | net/ssl/channel_id_service.cc » ('J')