Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: base/files/file_tracing.cc

Issue 1149083012: Simplify file tracing end events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simpler Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_tracing.h" 5 #include "base/files/file_tracing.h"
6 6
7 #include "base/files/file.h" 7 #include "base/files/file.h"
8 8
9 namespace base { 9 namespace base {
10 10
11 namespace { 11 namespace {
12 FileTracing::Provider* g_provider = nullptr; 12 FileTracing::Provider* g_provider = nullptr;
13 } 13 }
14 14
15 // static 15 // static
16 void FileTracing::SetProvider(FileTracing::Provider* provider) { 16 void FileTracing::SetProvider(FileTracing::Provider* provider) {
17 g_provider = provider; 17 g_provider = provider;
18 } 18 }
19 19
20 FileTracing::ScopedEnabler::ScopedEnabler() { 20 FileTracing::ScopedEnabler::ScopedEnabler() {
21 if (g_provider) 21 if (g_provider)
22 g_provider->FileTracingEnable(this); 22 g_provider->FileTracingEnable(this);
23 } 23 }
24 24
25 FileTracing::ScopedEnabler::~ScopedEnabler() { 25 FileTracing::ScopedEnabler::~ScopedEnabler() {
26 if (g_provider) 26 if (g_provider)
27 g_provider->FileTracingDisable(this); 27 g_provider->FileTracingDisable(this);
28 } 28 }
29 29
30 FileTracing::ScopedTrace::ScopedTrace() : initialized_(false) {} 30 FileTracing::ScopedTrace::ScopedTrace() : id_(nullptr) {}
31 31
32 FileTracing::ScopedTrace::~ScopedTrace() { 32 FileTracing::ScopedTrace::~ScopedTrace() {
33 if (initialized_ && g_provider) { 33 if (id_ && g_provider)
34 g_provider->FileTracingEventEnd( 34 g_provider->FileTracingEventEnd(name_, id_);
35 name_, &file_->trace_enabler_, file_->path_, size_);
36 }
37 } 35 }
38 36
39 bool FileTracing::ScopedTrace::ShouldInitialize() const { 37 bool FileTracing::ScopedTrace::ShouldInitialize() const {
40 return g_provider && g_provider->FileTracingCategoryIsEnabled(); 38 return g_provider && g_provider->FileTracingCategoryIsEnabled();
41 } 39 }
42 40
43 void FileTracing::ScopedTrace::Initialize( 41 void FileTracing::ScopedTrace::Initialize(
44 const char* name, File* file, int64 size) { 42 const char* name, File* file, int64 size) {
45 file_ = file; 43 if (!g_provider)
Dan Beam 2015/06/08 21:10:30 this prevents ends without corresponding begins
44 return;
45
46 id_ = &file->trace_enabler_;
46 name_ = name; 47 name_ = name;
47 size_ = size;
48 initialized_ = true;
49 48
50 if (g_provider) { 49 g_provider->FileTracingEventBegin(name_, id_, file->path_, size);
51 g_provider->FileTracingEventBegin(
52 name_, &file_->trace_enabler_, file_->path_, size_);
53 }
54 } 50 }
55 51
56 } // namespace base 52 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698