Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: sky/sdk/lib/framework/rendering/object.dart

Issue 1149083011: Include DETACHED, NEEDS-LAYOUT, and relayoutSubtreeRoot info in the debug output for the render tree (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/rendering/object.dart
diff --git a/sky/sdk/lib/framework/rendering/object.dart b/sky/sdk/lib/framework/rendering/object.dart
index 86eec6e2b1fc6786a93b7534cc1f9a5007ca7186..5aee1f85f49861e4bde64359554f6635ac23ef9c 100644
--- a/sky/sdk/lib/framework/rendering/object.dart
+++ b/sky/sdk/lib/framework/rendering/object.dart
@@ -222,9 +222,22 @@ abstract class RenderObject extends AbstractNode {
String toString([String prefix = '']) {
- String header = '${runtimeType}\n';
+ String header = '${runtimeType}';
+ if (_relayoutSubtreeRoot != null && _relayoutSubtreeRoot != this) {
+ int count = 1;
+ RenderObject target = parent;
+ while (target != null && target != _relayoutSubtreeRoot) {
+ target = target.parent as RenderObject;
+ count += 1;
+ }
+ header += ' relayoutSubtreeRoot=up$count';
+ }
+ if (_needsLayout)
+ header += ' NEEDS-LAYOUT';
+ if (!attached)
+ header += ' DETACHED';
prefix += ' ';
- return '${header}${debugDescribeSettings(prefix)}${debugDescribeChildren(prefix)}';
+ return '${header}\n${debugDescribeSettings(prefix)}${debugDescribeChildren(prefix)}';
}
String debugDescribeSettings(String prefix) => '${prefix}parentData: ${parentData}\n';
String debugDescribeChildren(String prefix) => '';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698