Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 1149083009: Force invalidation of LayoutText when text data changes (Closed)

Created:
4 years, 11 months ago by Xianzhu
Modified:
4 years, 11 months ago
Reviewers:
chrishtr, esprehn
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Force invalidation of LayoutText when text data changes Previously we missed paint invalidation when text data changes without layout change. About test expectation rebaselines: - Most of changes are changing incremental invalidations of LayoutTexts to full invalidations; - Some are additional invalidations of LayoutTexts, but they do no harm because they are covered by original bigger invalidations. BUG=493684 TEST=compositing/repaint/composited-inline-change-text-data-keep-geometry.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196531

Patch Set 1 #

Patch Set 2 : Update expectations (see previous try results for changes) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/compositing/repaint/composited-inline-change-text-data-keep-geometry.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/compositing/repaint/composited-inline-change-text-data-keep-geometry-expected.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutText.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Xianzhu
4 years, 11 months ago (2015-06-04 19:51:11 UTC) #2
chrishtr
lgtm
4 years, 11 months ago (2015-06-04 19:53:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149083009/10004
4 years, 11 months ago (2015-06-04 19:54:39 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 21:29:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:10004) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196531

Powered by Google App Engine
This is Rietveld 408576698