Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1149073004: Switch TestFrameNavigationObserver to DidCommitProvisionalLoadForFrame. (Closed)

Created:
5 years, 7 months ago by Charlie Reis
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch TestFrameNavigationObserver to DidCommitProvisionalLoadForFrame. This is necessary once we start classifying OOPIF commits correctly, since DidNavigateAnyFrame doesn't work for auto-subframe. BUG=464014 TEST=All navigation tests still pass Committed: https://crrev.com/6a68f40c237c8309a73687ffa747de997ce9396a Cr-Commit-Position: refs/heads/master@{#331613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M content/test/test_frame_navigation_observer.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/test/test_frame_navigation_observer.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Avi, can you take a look? This is necessary once I fix the commit type ...
5 years, 7 months ago (2015-05-27 17:26:00 UTC) #2
Avi (use Gerrit)
lgtm That works.
5 years, 7 months ago (2015-05-27 18:22:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149073004/1
5 years, 7 months ago (2015-05-27 18:36:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 18:41:37 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 18:42:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a68f40c237c8309a73687ffa747de997ce9396a
Cr-Commit-Position: refs/heads/master@{#331613}

Powered by Google App Engine
This is Rietveld 408576698