Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 1149063007: Expose the RenderView root through the AppView, so that you can change it. (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Expose the RenderView root through the AppView, so that you can change it. Also, attach the RenderView so that it actually updates during a flush layout. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2dc07a2cb6741128dca9cd54a2446256e425d4eb

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M sky/sdk/lib/framework/app.dart View 2 chunks +6 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
abarth-chromium
lgtm https://codereview.chromium.org/1149063007/diff/1/sky/sdk/lib/framework/app.dart File sky/sdk/lib/framework/app.dart (right): https://codereview.chromium.org/1149063007/diff/1/sky/sdk/lib/framework/app.dart#newcode25 sky/sdk/lib/framework/app.dart:25: _renderView.root = value; Do we need to schedule ...
5 years, 7 months ago (2015-05-27 16:52:49 UTC) #2
eseidel
Is this for framework or framework2?
5 years, 7 months ago (2015-05-27 16:58:15 UTC) #4
Hixie
On 2015/05/27 at 16:58:15, eseidel wrote: > Is this for framework or framework2? app.dart is ...
5 years, 7 months ago (2015-05-27 17:41:43 UTC) #5
Hixie
https://codereview.chromium.org/1149063007/diff/1/sky/sdk/lib/framework/app.dart File sky/sdk/lib/framework/app.dart (right): https://codereview.chromium.org/1149063007/diff/1/sky/sdk/lib/framework/app.dart#newcode25 sky/sdk/lib/framework/app.dart:25: _renderView.root = value; On 2015/05/27 at 16:52:48, abarth wrote: ...
5 years, 7 months ago (2015-05-27 17:41:47 UTC) #6
Hixie
5 years, 7 months ago (2015-05-27 17:42:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2dc07a2cb6741128dca9cd54a2446256e425d4eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698