Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1149063004: Revert of Save and restore unified mode (Closed)

Created:
5 years, 7 months ago by battre
Modified:
5 years, 7 months ago
Reviewers:
Jun Mukai, oshima
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Save and restore unified mode (patchset #5 id:140001 of https://codereview.chromium.org/1150913002/) Reason for revert: Revert due to memory leak. Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x61740b in operator new(unsigned long) (/tmp/run_tha_testilFjDM/out/Release/unit_tests+0x61740b) #1 0x40206a0 in chromeos::(anonymous namespace)::DisplayPreferencesTest::StoreDisplayBoolPropertyForPair(std::pair\u003Clong, long> const&, std::string const&, bool) chrome/browser/chromeos/display/display_preferences_unittest.cc:146:44 #2 0x401e200 in chromeos::DisplayPreferencesTest_RestoreUnifiedMode_Test::TestBody() chrome/browser/chromeos/display/display_preferences_unittest.cc:925:3 Original issue's description: > Save and restore unified mode > > BUG=489809 > TEST=DisplayPreferenceTest.SaveUnifiedMode/RestoreUnifiedMode > > Committed: https://crrev.com/b83c400b39840d0c18bd113559ea0040eb3c6b46 > Cr-Commit-Position: refs/heads/master@{#331076} TBR=mukai@chromium.org,oshima@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489809 Committed: https://crrev.com/de0c9e02748a95c5f93a236354e52fdacad53caa Cr-Commit-Position: refs/heads/master@{#331087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -214 lines) Patch
M ash/display/display_controller.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/display/display_layout.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/display/display_layout.cc View 5 chunks +3 lines, -9 lines 0 comments Download
M ash/display/display_layout_store.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ash/display/display_layout_store.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M ash/display/display_manager.cc View 3 chunks +3 lines, -21 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M ash/display/unified_mouse_warp_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/screen_util_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ash/system/chromeos/tray_display_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/test/display_manager_test_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/test/display_manager_test_api.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 7 chunks +27 lines, -132 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
Created Revert of Save and restore unified mode
5 years, 7 months ago (2015-05-22 09:46:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149063004/1
5 years, 7 months ago (2015-05-22 09:47:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 09:48:16 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 09:49:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de0c9e02748a95c5f93a236354e52fdacad53caa
Cr-Commit-Position: refs/heads/master@{#331087}

Powered by Google App Engine
This is Rietveld 408576698