Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: src/code-stubs.cc

Issue 1149053004: Make KeyedStores from a sloppy arguments array use a handler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Code comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs.h ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/cpu-profiler.h" 10 #include "src/cpu-profiler.h"
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 descriptor->Initialize( 630 descriptor->Initialize(
631 Runtime::FunctionForId(Runtime::kKeyedGetProperty)->entry); 631 Runtime::FunctionForId(Runtime::kKeyedGetProperty)->entry);
632 } 632 }
633 633
634 634
635 void HandlerStub::InitializeDescriptor(CodeStubDescriptor* descriptor) { 635 void HandlerStub::InitializeDescriptor(CodeStubDescriptor* descriptor) {
636 if (kind() == Code::STORE_IC) { 636 if (kind() == Code::STORE_IC) {
637 descriptor->Initialize(FUNCTION_ADDR(StoreIC_MissFromStubFailure)); 637 descriptor->Initialize(FUNCTION_ADDR(StoreIC_MissFromStubFailure));
638 } else if (kind() == Code::KEYED_LOAD_IC) { 638 } else if (kind() == Code::KEYED_LOAD_IC) {
639 descriptor->Initialize(FUNCTION_ADDR(KeyedLoadIC_MissFromStubFailure)); 639 descriptor->Initialize(FUNCTION_ADDR(KeyedLoadIC_MissFromStubFailure));
640 } else if (kind() == Code::KEYED_STORE_IC) {
641 descriptor->Initialize(FUNCTION_ADDR(KeyedStoreIC_MissFromStubFailure));
640 } 642 }
641 } 643 }
642 644
643 645
644 CallInterfaceDescriptor HandlerStub::GetCallInterfaceDescriptor() { 646 CallInterfaceDescriptor HandlerStub::GetCallInterfaceDescriptor() {
645 if (kind() == Code::LOAD_IC || kind() == Code::KEYED_LOAD_IC) { 647 if (kind() == Code::LOAD_IC || kind() == Code::KEYED_LOAD_IC) {
646 return LoadWithVectorDescriptor(isolate()); 648 return LoadWithVectorDescriptor(isolate());
647 } else { 649 } else {
648 DCHECK_EQ(Code::STORE_IC, kind()); 650 DCHECK(kind() == Code::STORE_IC || kind() == Code::KEYED_STORE_IC);
649 return StoreDescriptor(isolate()); 651 return StoreDescriptor(isolate());
650 } 652 }
651 } 653 }
652 654
653 655
654 void StoreFastElementStub::InitializeDescriptor( 656 void StoreFastElementStub::InitializeDescriptor(
655 CodeStubDescriptor* descriptor) { 657 CodeStubDescriptor* descriptor) {
656 descriptor->Initialize(FUNCTION_ADDR(KeyedStoreIC_MissFromStubFailure)); 658 descriptor->Initialize(FUNCTION_ADDR(KeyedStoreIC_MissFromStubFailure));
657 } 659 }
658 660
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
1039 } 1041 }
1040 1042
1041 1043
1042 InternalArrayConstructorStub::InternalArrayConstructorStub( 1044 InternalArrayConstructorStub::InternalArrayConstructorStub(
1043 Isolate* isolate) : PlatformCodeStub(isolate) { 1045 Isolate* isolate) : PlatformCodeStub(isolate) {
1044 InternalArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate); 1046 InternalArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
1045 } 1047 }
1046 1048
1047 1049
1048 } } // namespace v8::internal 1050 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.h ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698