Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1149043003: Fix ordering of recorders in SVGPaintContext (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix ordering of recorders in SVGPaintContext The compositing recorder should go out of scope ("end") before the (float) clip recorder to match the order in which they should be applied. BUG=490363 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195777

Patch Set 1 #

Patch Set 2 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
A LayoutTests/svg/custom/invalid-filter-reference-and-opacity-crash.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/invalid-filter-reference-and-opacity-crash-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/paint/SVGPaintContext.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
5 years, 7 months ago (2015-05-21 13:40:23 UTC) #2
pdr.
LGTM, steals always welcome ;) Could you add the small test from https://code.google.com/p/chromium/issues/detail?id=490363#c2? I have ...
5 years, 7 months ago (2015-05-21 20:41:39 UTC) #3
fs
On 2015/05/21 20:41:39, pdr wrote: ... > Could you add the small test from > ...
5 years, 7 months ago (2015-05-22 08:02:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149043003/20001
5 years, 7 months ago (2015-05-22 08:02:48 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 09:17:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195777

Powered by Google App Engine
This is Rietveld 408576698