Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1149013006: Execute the script using python api module. (Closed)

Created:
5 years, 7 months ago by prasadv
Modified:
5 years, 7 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Execute the script using python api module. step api module does not append python while executing a script, because of this the steps were throwing exeception on windows platform. Now we use python api module to execute scripts BUG=491470 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/api.py View 1 chunk +4 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_motoe_perf_bisect.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus10_perf_bisect.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus4_perf_bisect.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5_perf_bisect.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus6_perf_bisect.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus7_perf_bisect.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus9_perf_bisect.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_one_perf_bisect.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic.json View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
prasadv
IMPORTANT: At present all windows bisects are failing due the command execution exception. Please feel ...
5 years, 7 months ago (2015-05-23 04:48:05 UTC) #2
RobertoCN
On 2015/05/23 04:48:05, prasadv wrote: > IMPORTANT: At present all windows bisects are failing due ...
5 years, 7 months ago (2015-05-23 05:04:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149013006/1
5 years, 7 months ago (2015-05-23 05:04:33 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-23 05:04:36 UTC) #7
qyearsley
On 2015/05/23 04:48:05, prasadv wrote: > IMPORTANT: At present all windows bisects are failing due ...
5 years, 7 months ago (2015-05-23 05:06:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149013006/1
5 years, 7 months ago (2015-05-23 05:06:35 UTC) #10
commit-bot: I haz the power
Presubmit check for 1149013006-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 7 months ago (2015-05-23 05:09:22 UTC) #13
prasadv
Robbie or Aaron can you please stamp this CL
5 years, 7 months ago (2015-05-23 05:14:51 UTC) #15
iannucci
On 2015/05/23 05:14:51, prasadv wrote: > Robbie or Aaron can you please stamp this CL ...
5 years, 7 months ago (2015-05-23 05:57:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149013006/1
5 years, 7 months ago (2015-05-23 05:58:09 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-23 06:04:16 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295398

Powered by Google App Engine
This is Rietveld 408576698