PPAPI: Make Messaging not PostTask and copy when out-of-process.

webkit/plugins/ppapi/ppapi_plugin_instance.cc

Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc
diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.cc b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
index 1bc047761bc95f9757473cc5b9bf90bfa78e4a79..0d2909882401744502eab01571aa80c134a25d47 100644
--- a/webkit/plugins/ppapi/ppapi_plugin_instance.cc
+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
@@ -580,10 +580,13 @@ bool PluginInstance::Initialize(const std::vector<std::string>& arg_names,
   argv_ = arg_values;
   scoped_array<const char*> argn_array(StringVectorToArgArray(argn_));
   scoped_array<const char*> argv_array(StringVectorToArgArray(argv_));
-  return PP_ToBool(instance_interface_->DidCreate(pp_instance(),
-                                                  argn_.size(),
-                                                  argn_array.get(),
-                                                  argv_array.get()));
+  bool success =  PP_ToBool(instance_interface_->DidCreate(pp_instance(),
+                                                           argn_.size(),
+                                                           argn_array.get(),
+                                                           argv_array.get()));
+  if (success)
+    message_channel_->StopQueueingJavaScriptMessages();
+  return success;
 }
 
 bool PluginInstance::HandleDocumentLoad(PPB_URLLoader_Impl* loader) {
@@ -2386,6 +2389,10 @@ bool PluginInstance::ResetAsProxied(scoped_refptr<PluginModule> module) {
   original_module_ = module_;
   module_ = module;
 
+  // We're changing the plugin's relationship to the DOM; don't send any

[dmichael (off chromium), 2012/12/11 22:35:30]

I think you can just remove the part before the semicolon...

maybe append something like ", otherwise we might be re-entered while we are in
an invalid state."
or something.

[teravest, 2012/12/11 22:43:39]

Done.

+  // messages to the plugin until DidCreate() has finished.
+  message_channel_->QueueJavaScriptMessages();
+
   // For NaCl instances, remember the NaCl plugin instance interface, so we
   // can shut it down by calling its DidDestroy in our Delete() method.
   original_instance_interface_.reset(instance_interface_.release());
@@ -2420,6 +2427,7 @@ bool PluginInstance::ResetAsProxied(scoped_refptr<PluginModule> module) {
   if (!instance_interface_->DidCreate(pp_instance(), argn_.size(),
                                       argn_array.get(), argv_array.get()))
     return false;
+  message_channel_->StopQueueingJavaScriptMessages();
 
   // Clear sent_initial_did_change_view_ and cancel any pending DidChangeView
   // event. This way, SendDidChangeView will send the "current" view