Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1148983006: Stage ES6 Array and TypedArray methods (Closed)

Created:
5 years, 6 months ago by adamk
Modified:
5 years, 6 months ago
CC:
v8-dev, rossberg, dehrenberg, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage ES6 Array and TypedArray methods Also stages ES6 @@isConcatSpreadable support. BUG=v8:3578 LOG=y Committed: https://crrev.com/131062fc41e2d95c9ae7b0913b7efb8e32785e2c Cr-Commit-Position: refs/heads/master@{#28805}

Patch Set 1 #

Patch Set 2 : Update test262 status to reflect now-passing tests #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -49 lines) Patch
M src/flag-definitions.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 3 chunks +3 lines, -47 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
adamk
5 years, 6 months ago (2015-06-04 17:24:16 UTC) #2
arv (Not doing code reviews)
That failure looks strange.
5 years, 6 months ago (2015-06-04 18:47:11 UTC) #3
adamk
Updated the test262 test status, the mozilla failures look like unrelated flakes.
5 years, 6 months ago (2015-06-04 19:36:44 UTC) #4
arv (Not doing code reviews)
LGTM
5 years, 6 months ago (2015-06-04 19:37:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148983006/40001
5 years, 6 months ago (2015-06-04 19:39:57 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-04 20:08:32 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 20:08:47 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/131062fc41e2d95c9ae7b0913b7efb8e32785e2c
Cr-Commit-Position: refs/heads/master@{#28805}

Powered by Google App Engine
This is Rietveld 408576698