Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1148973005: Revert of Remove obsolete JSFunction::IsOptimizable predicate. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-15
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove obsolete JSFunction::IsOptimizable predicate. (patchset #1 id:1 of https://codereview.chromium.org/1150683002/) Reason for revert: Causes assertions to fire when serializing optimized code. Original issue's description: > Remove obsolete JSFunction::IsOptimizable predicate. > > This just delegates to SharedFunctionInfo::optimization_disabled and > was primarily used for assertions. Removing it due to misleading name > because already optimized functions reported being "non-optimizable". > > R=titzer@chromium.org > > Committed: https://crrev.com/181d7b85977eb752b19e1de902093783e31330ef > Cr-Commit-Position: refs/heads/master@{#28551} TBR=titzer@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9d9acf55421bbbf729140d81eabc4d6a36b73f87 Cr-Commit-Position: refs/heads/master@{#28554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime-profiler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
Created Revert of Remove obsolete JSFunction::IsOptimizable predicate.
5 years, 7 months ago (2015-05-21 13:34:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148973005/1
5 years, 7 months ago (2015-05-21 13:34:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 13:35:00 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 13:35:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d9acf55421bbbf729140d81eabc4d6a36b73f87
Cr-Commit-Position: refs/heads/master@{#28554}

Powered by Google App Engine
This is Rietveld 408576698