purge imagefilter cache so we can better track leaks

purge imagefilter cache so we can better track leaks

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/67ca2a93f9269768fac39be4406dc167bea6d716

[reed1, 2015-05-20 20:16:44]

reed@google.com changed reviewers:
+ robertphillips@google.com, senorblanco@google.com

[reed1, 2015-05-20 20:16:48]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-05-20 20:17:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148973002/1

[commit-bot: I haz the power, 2015-05-20 20:17:01]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-05-21 02:17 UTC

[Stephen White, 2015-05-20 20:21:14]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2015-05-20 20:21:15]

LGTM, as long as SkGraphics::PurgeResourceCache() is only called on process
exit.

[commit-bot: I haz the power, 2015-05-20 20:23:00]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/67ca2a93f9269768fac39be4406dc167bea6d716

[robertphillips, 2015-05-20 20:28:19]

Whoops - too late :(

https://codereview.chromium.org/1148973002/diff/1/include/core/SkImageFilter.h
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1148973002/diff/1/include/core/SkImageFilter....
include/core/SkImageFilter.h:345: private:
// for PurgeCache call ?

https://codereview.chromium.org/1148973002/diff/1/src/core/SkImageFilter.cpp
File src/core/SkImageFilter.cpp (right):

https://codereview.chromium.org/1148973002/diff/1/src/core/SkImageFilter.cpp#...
src/core/SkImageFilter.cpp:473: }
this-> ?

https://codereview.chromium.org/1148973002/diff/1/src/core/SkImageFilter.cpp#...
src/core/SkImageFilter.cpp:518: void SkImageFilter::PurgeCache() {
Should this be gCache ?

[reed1, 2015-05-20 20:29:45]

On 2015/05/20 20:21:15, Stephen White wrote:
> LGTM, as long as SkGraphics::PurgeResourceCache() is only called on process
> exit.

It can be called before then. Why this restriction?

[Stephen White, 2015-05-20 20:40:10]

On 2015/05/20 20:29:45, reed1 wrote:
> On 2015/05/20 20:21:15, Stephen White wrote:
> > LGTM, as long as SkGraphics::PurgeResourceCache() is only called on process
> > exit.
> 
> It can be called before then. Why this restriction?

I meant as long as it's not called frequently (e.g., between frames), negating
the point of the cache. But I doubt that's the case.

[reed1, 2015-05-20 20:49:14]

Ah, ok. It will be called whenever someone calls it :)

For this CL, I am calling it when I purge all the other caches as well.