Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1148963007: Fix a missing url_request mojom import in fetch.dart. (Closed)

Created:
5 years, 6 months ago by ppi
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jamesr, mojo-reviews_chromium.org, qsr+mojo_chromium.org, rudominer
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix a missing url_request mojom import in fetch.dart. Not exactly sure what I'm doing, but this makes the stocks example: `sky/tools/skydb start out/Debug/ sky/examples/stocks/main.sky` work again, fixing the UrlRequest import issue: [0603/143348:ERROR:dart_error.cc(20)] 'http://localhost:9999/packages/sky/framework/net/fetch.dart': malformed type: line 32 pos 21: type 'UrlRequest' is not loaded var request = new UrlRequest() R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/db73217e1ca565e3c9b208643154b879caa6d96f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sky/sdk/lib/framework/net/fetch.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Adam or Eric, ptal.
5 years, 6 months ago (2015-06-03 12:42:42 UTC) #2
eseidel
lgtm Dart doesn't re-export symbols from other libaries. So if url_request recently split out from ...
5 years, 6 months ago (2015-06-03 14:50:30 UTC) #3
ppi
5 years, 6 months ago (2015-06-03 14:56:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db73217e1ca565e3c9b208643154b879caa6d96f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698