Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1148963003: X87: Vector ICs: Introduce Store and KeyedStore IC code stubs. (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Vector ICs: Introduce Store and KeyedStore IC code stubs. port a86384f192f88458bb46eece0a8f2709979057b8 (r28597). original commit message: Also introduce new interface descriptors for the trampoline and full versions of those stubs. Currently, the stubs aren't functional. BUG= Committed: https://crrev.com/47448c9b19c6c64eda9c6f8f9b4bab5d4a61beee Cr-Commit-Position: refs/heads/master@{#28605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 7 months ago (2015-05-25 10:09:30 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-25 12:51:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148963003/1
5 years, 7 months ago (2015-05-25 12:51:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-25 13:13:39 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 13:13:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47448c9b19c6c64eda9c6f8f9b4bab5d4a61beee
Cr-Commit-Position: refs/heads/master@{#28605}

Powered by Google App Engine
This is Rietveld 408576698