Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 1148953014: Fix the commit type for out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.h
diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h
index ee00ca4e398b118dc75db9c24427bce5cedd455a..3a38bd05042eb250ca4be954c20a3098ff864046 100644
--- a/content/browser/frame_host/navigation_controller_impl.h
+++ b/content/browser/frame_host/navigation_controller_impl.h
@@ -20,6 +20,7 @@
struct FrameHostMsg_DidCommitProvisionalLoad_Params;
namespace content {
+class FrameTreeNode;
class RenderFrameHostImpl;
class NavigationEntryScreenshotManager;
class SiteInstance;
@@ -116,6 +117,11 @@ class CONTENT_EXPORT NavigationControllerImpl
SiteInstance* instance,
int32 page_id) const;
+ // Whether the given frame has committed any navigations yet.
+ // This currently only returns true in --site-per-process mode.
+ // TODO(creis): Create FrameNavigationEntries by default so this always works.
+ bool HasCommittedRealLoad(FrameTreeNode* frame_tree_node) const;
+
NavigationControllerDelegate* delegate() const {
return delegate_;
}

Powered by Google App Engine
This is Rietveld 408576698