Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1148953009: Fix overflow in allocation throughput calculation. (Closed)

Created:
5 years, 6 months ago by Hannes Payer (out of office)
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix overflow in allocation throughput calculation. BUG=chromium:492021 LOG=n Committed: https://crrev.com/3e9c664b8c2d661e616e96c7b0db4be65f12b612 Cr-Commit-Position: refs/heads/master@{#28638}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M src/heap/gc-tracer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.cc View 2 2 chunks +4 lines, -7 lines 0 comments Download
M test/cctest/test-heap.cc View 1 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Hannes Payer (out of office)
5 years, 6 months ago (2015-05-26 16:46:19 UTC) #2
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-05-26 17:44:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148953009/40001
5 years, 6 months ago (2015-05-26 17:44:56 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-05-26 17:46:55 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3e9c664b8c2d661e616e96c7b0db4be65f12b612 Cr-Commit-Position: refs/heads/master@{#28638}
5 years, 6 months ago (2015-05-26 17:47:09 UTC) #8
ulan
5 years, 6 months ago (2015-05-26 20:04:23 UTC) #9
Message was sent while issue was closed.
lgtm, thanks for fixing!

Powered by Google App Engine
This is Rietveld 408576698