Cast pointers used with %p format strings to void *

tests/mmap/mmap_test.cc

Index: tests/mmap/mmap_test.cc
diff --git a/tests/mmap/mmap_test.cc b/tests/mmap/mmap_test.cc
index 52757d1933ff62ad9e4277efff8a6438dd27aa72..52f535b96c663157779d99a607a3030817f51f64 100644
--- a/tests/mmap/mmap_test.cc
+++ b/tests/mmap/mmap_test.cc
@@ -81,7 +81,7 @@ static void assert_addr_is_unreadable(volatile char *addr) {
     char value = *addr;
     /* If we reach here, the assertion failed. */
     fprintf(stderr, "Address %p was readable, and contained %i\n",
-            addr, value);
+            static_cast<void *>(addr), value);

[Derek Schuff, 2015/05/20 22:03:44]

so, you can't cast away volatile like this with any C++ cast. You can
reinterpret_cast to uintptr_t and use %x instead (ugly) or use a c-style cast
(less ugly?) with %p.

[khimg, 2015/05/20 22:16:18]

Ugh. uintptr_t would properly require not %x but %" PRIxPTR " which is
definitely too ugly and fragile. I think c-style cast with a comment is the best
choice.

[Derek Schuff, 2015/05/22 16:38:49]

agreed; switched to c-style casts with comment.

     exit(1);
   }
   /*
@@ -121,7 +121,7 @@ static void assert_addr_is_unwritable(volatile char *addr, char value) {
     *addr = value;
     /* If we reach here, the assertion failed. */
     fprintf(stderr, "Address %p was writable, %i was written\n",
-            addr, value);
+            static_cast<void *>(addr), value);
     exit(1);
   }
   /*