Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: tests/mmap/mmap_test.cc

Issue 1148953002: Cast pointers used with %p format strings to void * (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/mmap/mmap_test.cc
diff --git a/tests/mmap/mmap_test.cc b/tests/mmap/mmap_test.cc
index 52757d1933ff62ad9e4277efff8a6438dd27aa72..4e6bcff3d1c525adc7002f270082911cf212ff63 100644
--- a/tests/mmap/mmap_test.cc
+++ b/tests/mmap/mmap_test.cc
@@ -81,7 +81,7 @@ static void assert_addr_is_unreadable(volatile char *addr) {
char value = *addr;
/* If we reach here, the assertion failed. */
fprintf(stderr, "Address %p was readable, and contained %i\n",
- addr, value);
+ (void *)addr, value);
khimg 2015/05/20 20:44:12 Why C cast? It's C++ file, not C, style guide forb
Derek Schuff 2015/05/20 21:32:07 Done.
exit(1);
}
/*
@@ -121,7 +121,7 @@ static void assert_addr_is_unwritable(volatile char *addr, char value) {
*addr = value;
/* If we reach here, the assertion failed. */
fprintf(stderr, "Address %p was writable, %i was written\n",
- addr, value);
+ (void *)addr, value);
exit(1);
}
/*

Powered by Google App Engine
This is Rietveld 408576698