tests/libc/memcpy_move_set.c - Issue 1148953002: Cast pointers used with %p format strings to void *

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/libc/memcpy_move_set.c

Issue 1148953002: Cast pointers used with %p format strings to void * (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests/dynamic_code_loading/dyncode_demand_alloc_test.c ('K') | « tests/dynamic_code_loading/dyncode_demand_alloc_test.c ('k') | tests/libc/posix_memalign.c » ('j') | tests/mmap/mmap_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/libc/memcpy_move_set.c

diff --git a/tests/libc/memcpy_move_set.c b/tests/libc/memcpy_move_set.c

index b526c72fbeae51ceb3537a4c42a7ed0bc66bccc4..b5f3151af065dc52a7c51804333fb909b5bec4a5 100644

--- a/tests/libc/memcpy_move_set.c

+++ b/tests/libc/memcpy_move_set.c

@@ -44,7 +44,7 @@ void reset_buf(void) {

void dump_buf(void) {

unsigned char *bufptr = (unsigned char *) buf;

for (int i = 0; i < total_buf_len; ++i)

- printf("buf[%u] (%p) = %u\n", i, &bufptr[i], bufptr[0]);

+ printf("buf[%u] (%p) = %u\n", i, (void *)&bufptr[i], bufptr[0]);

}

@@ -85,7 +85,8 @@ void checked_memset(void *s, int c, unsigned n) {

char *dst_char = s_char;

for (unsigned i = 0; i < n; ++i, ++dst_char) {

if (*dst_char != c) {

- printf("memset failure: index %d (%p) = %u\n", i, dst_char, *dst_char);

+ printf("memset failure: index %d (%p) = %u\n",

+ i, (void *)dst_char, *dst_char);

dump_buf();

exit(1);

}