Cast pointers used with %p format strings to void *

tests/mmap/mmap_test.cc

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <limits.h>
@@ skipping 63 matching lines @@
             "nonsfi_loader with host libc\n");
     return;
   }
 
   int rc = nacl_exception_set_handler(exception_handler);
   assert(rc == 0);
   if (!setjmp(g_jmp_buf)) {
     char value = *addr;
     /* If we reach here, the assertion failed. */
     fprintf(stderr, "Address %p was readable, and contained %i\n",
-            addr, value);
+            static_cast<void *>(addr), value);

[Derek Schuff, 2015/05/20 22:03:44]

so, you can't cast away volatile like this with any C++ cast. You can
reinterpret_cast to uintptr_t and use %x instead (ugly) or use a c-style cast
(less ugly?) with %p.

[khimg, 2015/05/20 22:16:18]

Ugh. uintptr_t would properly require not %x but %" PRIxPTR " which is
definitely too ugly and fragile. I think c-style cast with a comment is the best
choice.

[Derek Schuff, 2015/05/22 16:38:49]

agreed; switched to c-style casts with comment.

     exit(1);
   }
   /*
    * Clean up: Unregister the exception handler so that we do not
    * accidentally return through g_jmp_buf if an exception occurs.
    */
   rc = nacl_exception_set_handler(NULL);
   assert(rc == 0);
 }
 
@@ skipping 19 matching lines @@
             "nonsfi_loader with host libc\n");
     return;
   }
 
   int rc = nacl_exception_set_handler(exception_handler);
   assert(rc == 0);
   if (!setjmp(g_jmp_buf)) {
     *addr = value;
     /* If we reach here, the assertion failed. */
     fprintf(stderr, "Address %p was writable, %i was written\n",
-            addr, value);
+            static_cast<void *>(addr), value);
     exit(1);
   }
   /*
    * Clean up: Unregister the exception handler so that we do not
    * accidentally return through g_jmp_buf if an exception occurs.
    */
   rc = nacl_exception_set_handler(NULL);
   assert(rc == 0);
 }
 
@@ skipping 499 matching lines @@
   // run the full test suite
   passed = testSuite();
 
   if (passed) {
     printf("All tests PASSED\n");
     exit(0);
   }
   printf("One or more tests FAILED\n");
   exit(-1);
 }