Cast pointers used with %p format strings to void *

Cast pointers used with %p format strings to void *

Clang's upcoming -Wformat-pedantic warning wants this.

R=mcgrathr@chromium.org
BUG=none

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/561075fe3e64272c283340feed96f3f2435173a2

[khimg, 2015-05-20 20:44:11]

khim@google.com changed reviewers:
+ khim@google.com

[khimg, 2015-05-20 20:44:12]

https://codereview.chromium.org/1148953002/diff/40001/tests/mmap/mmap_test.cc
File tests/mmap/mmap_test.cc (right):

https://codereview.chromium.org/1148953002/diff/40001/tests/mmap/mmap_test.cc...
tests/mmap/mmap_test.cc:84: (void *)addr, value);
Why C cast? It's C++ file, not C, style guide forbids that...

[Roland McGrath, 2015-05-20 20:51:53]

In C code, it should be '(void *) expr' (space).
In C++ code, it should be 'static_cast<void*>(expr)'.
LGTM with those cosmetic fixes and happy trybots.

https://codereview.chromium.org/1148953002/diff/40001/tests/dynamic_code_load...
File tests/dynamic_code_loading/dyncode_demand_alloc_test.c (right):

https://codereview.chromium.org/1148953002/diff/40001/tests/dynamic_code_load...
tests/dynamic_code_loading/dyncode_demand_alloc_test.c:41: fprintf(stderr,
"Mismatch at %p\n", (void *)ptr);
Our style uses a space after the cast.

[Derek Schuff, 2015-05-20 21:32:07]

https://codereview.chromium.org/1148953002/diff/40001/tests/dynamic_code_load...
File tests/dynamic_code_loading/dyncode_demand_alloc_test.c (right):

https://codereview.chromium.org/1148953002/diff/40001/tests/dynamic_code_load...
tests/dynamic_code_loading/dyncode_demand_alloc_test.c:41: fprintf(stderr,
"Mismatch at %p\n", (void *)ptr);
On 2015/05/20 20:51:53, Roland McGrath wrote:
> Our style uses a space after the cast.

Done.

https://codereview.chromium.org/1148953002/diff/40001/tests/mmap/mmap_test.cc
File tests/mmap/mmap_test.cc (right):

https://codereview.chromium.org/1148953002/diff/40001/tests/mmap/mmap_test.cc...
tests/mmap/mmap_test.cc:84: (void *)addr, value);
On 2015/05/20 20:44:12, khimg wrote:
> Why C cast? It's C++ file, not C, style guide forbids that...

Done.

[Roland McGrath, 2015-05-20 21:35:43]

lgtm

[Derek Schuff, 2015-05-20 22:03:44]

https://codereview.chromium.org/1148953002/diff/80001/tests/mmap/mmap_test.cc
File tests/mmap/mmap_test.cc (right):

https://codereview.chromium.org/1148953002/diff/80001/tests/mmap/mmap_test.cc...
tests/mmap/mmap_test.cc:84: static_cast<void *>(addr), value);
so, you can't cast away volatile like this with any C++ cast. You can
reinterpret_cast to uintptr_t and use %x instead (ugly) or use a c-style cast
(less ugly?) with %p.

[khimg, 2015-05-20 22:16:18]

https://codereview.chromium.org/1148953002/diff/80001/tests/mmap/mmap_test.cc
File tests/mmap/mmap_test.cc (right):

https://codereview.chromium.org/1148953002/diff/80001/tests/mmap/mmap_test.cc...
tests/mmap/mmap_test.cc:84: static_cast<void *>(addr), value);
On 2015/05/20 22:03:44, Derek Schuff wrote:
> so, you can't cast away volatile like this with any C++ cast. You can
> reinterpret_cast to uintptr_t and use %x instead (ugly) or use a c-style cast
> (less ugly?) with %p.

Ugh. uintptr_t would properly require not %x but %" PRIxPTR " which is
definitely too ugly and fragile. I think c-style cast with a comment is the best
choice.

[Derek Schuff, 2015-05-22 16:38:50]

https://codereview.chromium.org/1148953002/diff/80001/tests/mmap/mmap_test.cc
File tests/mmap/mmap_test.cc (right):

https://codereview.chromium.org/1148953002/diff/80001/tests/mmap/mmap_test.cc...
tests/mmap/mmap_test.cc:84: static_cast<void *>(addr), value);
On 2015/05/20 22:16:18, khimg wrote:
> On 2015/05/20 22:03:44, Derek Schuff wrote:
> > so, you can't cast away volatile like this with any C++ cast. You can
> > reinterpret_cast to uintptr_t and use %x instead (ugly) or use a c-style
cast
> > (less ugly?) with %p.
> 
> Ugh. uintptr_t would properly require not %x but %" PRIxPTR " which is
> definitely too ugly and fragile. I think c-style cast with a comment is the
best
> choice.

agreed; switched to c-style casts with comment.

[Derek Schuff, 2015-05-22 19:17:54]

The CQ bit was checked by dschuff@chromium.org

[Derek Schuff, 2015-05-22 19:17:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mcgrathr@chromium.org
Link to the patchset: https://codereview.chromium.org/1148953002/#ps100001
(title: "use C-style everywhere")

[commit-bot: I haz the power, 2015-05-22 19:18:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148953002/100001

[commit-bot: I haz the power, 2015-05-22 19:19:17]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/native_client/src/native_client/+/561075fe3...